fix: mark skins applied only after pack files exist - #30
Merged
Merged
Conversation
Reload and submission delete copied every approved id into the pending queue, and the next pack zip acked them. The website then showed those skins as live with no ItemsAdder config on disk. Co-authored-by: Cursor <[email protected]>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/armourshop reload, pack sync, and submission delete from copying every approved-but-unwritten skin into the pending-reload queue.iazip, and only when its ItemsAdder config is on disk. Missing configs stay approved so the next pack pull can write them.Test plan
ApplyAckPlannerTestpasses in CI/armourshop reloaddoes not log a pending-queue import of unwritten approvalsSummary by CodeRabbit
/armourshop pack pull.