fix: let console run ArmourShop admin commands - #28
Conversation
armourshop.admin was declared with default: false, so the console (op) was denied. AMP's daily 07:00 `armourshop pack pull` console task has failed with "You do not have access to this command" every day. Default the permission to op so the console passes. ops.json on Main is empty, so no players gain access; LuckPerms grants are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe ChangesAdmin permission default
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change enables the console’s admin commands; operators also receive the configured permission, while effective LuckPerms denials still apply. No material merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the plugin file, Comment |
Problem
armourshop.adminis declared withdefault: false, which denies it even to ops and the console. AMP on TFMCMain01 sendsarmourshop pack pullto the console at 07:00 each day, and it has failed every day with:armourshop reloadfrom the console is silently ignored for the same reason.(The plugin's own
force-reload-time: "06:00"pull also never fires, because AMP stops the server at exactly 06:00. With this fix, the 07:00 AMP task covers the daily pull.)Change
plugin.yml:armourshop.admindefault: false->default: op.The console always counts as op, so it now passes.
ops.jsonon Main is empty, so no players gain access. LuckPerms grants and explicit denials still take priority.Testing
armourshop pack pullruns🤖 Generated with Claude Code
Summary by CodeRabbit
armourshop.adminpermission is now granted by default to server operators.