Skip to content

fix: let console run ArmourShop admin commands - #28

Merged
XxFran10xX merged 1 commit into
mainfrom
fix/console-admin-permission
Sep 26, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
fix/console-admin-permission

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Problem

armourshop.admin is declared with default: false, which denies it even to ops and the console. AMP on TFMCMain01 sends armourshop pack pull to the console at 07:00 each day, and it has failed every day with:

[07:00:00] [ArmourShop] You do not have access to this command

armourshop reload from the console is silently ignored for the same reason.

(The plugin's own force-reload-time: "06:00" pull also never fires, because AMP stops the server at exactly 06:00. With this fix, the 07:00 AMP task covers the daily pull.)

Change

plugin.yml: armourshop.admin default: false -> default: op.

The console always counts as op, so it now passes. ops.json on Main is empty, so no players gain access. LuckPerms grants and explicit denials still take priority.

Testing

  • CI build
  • Loaded on TFMCDev01; console armourshop pack pull runs

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Changes
    • The armourshop.admin permission is now granted by default to server operators.

armourshop.admin was declared with default: false, so the console (op)
was denied. AMP's daily 07:00 `armourshop pack pull` console task has
failed with "You do not have access to this command" every day.

Default the permission to op so the console passes. ops.json on Main
is empty, so no players gain access; LuckPerms grants are unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a9288591-6f5d-4baf-a115-cb3699be65ce

📥 Commits

Reviewing files that changed from the base of the PR and between ee23e74 and 1973bf1.

📒 Files selected for processing (1)
  • src/main/resources/plugin.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The armourshop.admin permission now defaults to operators instead of false.

Changes

Admin permission default

Layer / File(s) Summary
Set the permission default
src/main/resources/plugin.yml
The armourshop.admin permission now defaults to operators instead of false.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to 1973b

The change enables the console’s admin commands; operators also receive the configured permission, while effective LuckPerms denials still apply. No material merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 1973b

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/main/resources/plugin.yml: armourshop.admin now defaults to operators; previously it defaulted to false.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: allowing the console to run ArmourShop admin commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the plugin file,
An operator gains the right.
The admin setting shifts its default,
From false to operator overnight.
The rabbit hops and marks the change,
Then nibbles clover in delight.

Comment @coderabbitai help to get the list of available commands.

@XxFran10xX
XxFran10xX merged commit c7b3f79 into main Sep 26, 2026
2 checks passed
@XxFran10xX
XxFran10xX deleted the fix/console-admin-permission branch September 26, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant