Skip to content

ci: pin shared plugin setup to TLibs main - #27

Merged
ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references
Sep 24, 2026
Merged

ryanbarlow97 merged 1 commit into
mainfrom
chore/remove-legacy-references

Conversation

@ryanbarlow97

@ryanbarlow97 ryanbarlow97 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Pin TF-Minecraft/TLibs/.github/actions/setup-plugins to 8ef41de on TLibs main. The previous pin, 4f7a354, is the head of TLibs PR fix: resolve build warnings #19 and is not on any branch (fix: resolve build warnings #19 was squash-merged as 8f48e6f). The action itself is unchanged; since then the installer has only dropped its unused --assets option and added GemInfusion to its catalogue.
  • Remove -P'!deploy-live' from the Maven commands. No POM defines a deploy-live profile, so the flag does nothing.

Verification

  • The build workflow runs on this PR. The release workflow gets the same edits but only runs on tags.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated build and release workflows to follow the project’s standard live-deployment profile settings when setting versions, evaluating artifact names, and verifying changes. This may affect which deployment-related steps run during those workflows.

The setup-plugins action was pinned to 4f7a354, the head of TLibs PR #19,
which is not on any TLibs branch. Pin it to 8ef41de on TLibs main. The
action is unchanged; its installer catalogue now also lists GemInfusion.

Drop -P'!deploy-live'. No POM defines a deploy-live profile, so the flag
does nothing.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3b5e0927-9ed8-4280-baec-bd94fd374006

📥 Commits

Reviewing files that changed from the base of the PR and between eb3c501 and 12e44f9.

📒 Files selected for processing (2)
  • .github/workflows/build.yml
  • .github/workflows/maven-release.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

Both Maven workflows use an updated shared plugin setup action pin. Their version-setting, final-name evaluation, and clean verification commands no longer explicitly exclude the deploy-live profile.

Changes

Maven workflows

Layer / File(s) Summary
Workflow setup and profile handling
.github/workflows/build.yml, .github/workflows/maven-release.yml
Both workflows use a new shared plugin setup action pin. Their listed Maven commands no longer explicitly exclude the deploy-live profile.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 12e44

The repository defines no deploy-live profile or workflow-managed Maven settings, so no concrete build behavior change is established. No actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: pinning the shared plugin setup action to TLibs main. It accurately reflects the main objective, although it does not mention the secondary Maven profi…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

I’m a rabbit, ears held high,
I watched the Maven commands fly.
The profile’s no longer barred,
The workflow pins are updated, guard by guard.
I nibble clover, then I hop,
While build and release run their shop.

Comment @coderabbitai help to get the list of available commands.

@ryanbarlow97
ryanbarlow97 merged commit ee23e74 into main Sep 24, 2026
2 checks passed
@ryanbarlow97
ryanbarlow97 deleted the chore/remove-legacy-references branch September 24, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant