Skip to content

fix: sync the default model scheme with the live server and add bronze models - #26

Merged
XxFran10xX merged 1 commit into
mainfrom
fix/bronze-model-scheme
Sep 27, 2026
Merged

XxFran10xX merged 1 commit into
mainfrom
fix/bronze-model-scheme

Conversation

@XxFran10xX

@XxFran10xX XxFran10xX commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

The bundled model-schemes/basic.yml had drifted from the one TFMCMain01 uses. This makes the default match the live file, which now also includes the bronze models.

Fixes that were only on live

  • Every metal spelled warhammher, but the recipe type is warhammer, so getModel found nothing and warhammers were crafted without a metal model ("AC: No model in the scheme …").
  • Steel spear now iron_hoe.3 (was .2, the iron spear). Abyssalite polearm now iron_hoe.8 (was .9, the mythril polearm).
  • Added shortsword and lute for each metal, shield and banner for each wood, and the mage scheme.

Bronze

  • Spear iron_hoe.10 and polearm iron_hoe.11: its own models (the old default used steel's spear and abyssalite's polearm).
  • Shortsword iron_sword.49 and lute iron_shovel.24: the new bronze models from TF-Minecraft/ServerAssets#19.
  • Helmet, chestplate, leggings and boots → ia.tfmc_armor:bronze_*: the new bronze armor set (it used steel's).

The committed file is byte-identical to plugins/AdvancedCrafting/model-schemes/basic.yml on TFMCMain01. The plugin never writes model-schemes/ itself (it isn't in createConfigs), so servers keep using their own file. This keeps the repo copy, the reference for new setups, in line with the one in use.

Tested on TFMCDev01

With this file, admin crafts at a forging station gave a bronze light helmet with the tfmc_armor:bronze_helmet look (dye #b38e5d, CMD 10195), a shortsword on iron_sword CMD 49 and a lute on iron_shovel CMD 24.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added shortsword and lute options for iron, steel, bronze, abyssalite, and mythril materials.
    • Added shield and banner visuals for barkwood, maplewood, elderwood, and demonwood.
    • Added mage armor visuals.
  • Updates
    • Updated bronze weapon and armor visuals, including spear, polearm, and shortsword mappings.
    • Corrected the Warhammer name.

…e models

The bundled basic.yml had drifted from the one TFMCMain01 uses. Its
warhammer entries were spelled "warhammher", so warhammers never got a
metal model, the steel spear and abyssalite polearm pointed at other
metals, and shortsword, lute, shield, banner and the mage scheme were
missing.

Bronze now uses its own models: the shortsword on iron_sword 49, the
lute on iron_shovel 24, and the tfmc_armor bronze armor set.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6d708a8c-32ee-4b55-acb9-4a71f0ea49fb

📥 Commits

Reviewing files that changed from the base of the PR and between 9ce37f3 and cc756f5.

📒 Files selected for processing (1)
  • src/main/resources/model-schemes/basic.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The basic model schemes correct warhammer identifiers and add weapon mappings. Bronze armor and weapon mappings are updated, a mage armor scheme is added, and wooden material schemes gain shield and banner mappings.

Changes

Basic model scheme mappings

Layer / File(s) Summary
Metal equipment mappings
src/main/resources/model-schemes/basic.yml
Iron, steel, bronze, abyssalite, and mythril correct the warhammer mapping and add shortsword and lute mappings. Bronze also updates spear and polearm indices and uses ia.tfmc_armor identifiers for its armor.
Mage armor mappings
src/main/resources/model-schemes/basic.yml
A new mage scheme maps the helmet, chestplate, leggings, and boots to ia.tfmc_armor identifiers.
Wooden material mappings
src/main/resources/model-schemes/basic.yml
Barkwood, maplewood, elderwood, and demonwood gain shield and banner mappings.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: ryanbarlow97

Merge Risk: ⚪ Minimal · up to cc756

The bundled warhammer mapping now matches its recipe, and no concrete breakage is established for the added mappings. External model assets could not be checked, so their availability remains unverified.

Architecture Summary

Architecture risk: 🔵 Low · up to cc756

The change affects 1 system.

Changed systems: src

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in src/main/resources/model-schemes/basic.yml: The iron scheme corrects the warhammer model name and adds shortsword and lute mappings.
  • observed — Modified behavior in src/main/resources/model-schemes/basic.yml: The steel scheme corrects the warhammer model name and adds shortsword and lute mappings.
  • observed — Modified behavior in src/main/resources/model-schemes/basic.yml: The bronze scheme corrects the warhammer model name, changes spear and polearm model indices, adds shortsword and lute mappings, and replaces vanilla iron armor models with ia.tfmc_armor bronze armor identifiers.
  • observed — Modified behavior in src/main/resources/model-schemes/basic.yml: The abyssalite scheme corrects the warhammer model name and adds shortsword and lute mappings.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary changes: synchronizing the default model scheme with the live server and adding bronze model mappings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

A rabbit checks the model rows,
A lute appears, a shortsword shows.
Bronze armor finds its proper name,
Mage gear joins the mapping game.
Wood shields and banners hop in place.

Comment @coderabbitai help to get the list of available commands.

@XxFran10xX
XxFran10xX merged commit 07565e2 into main Sep 27, 2026
2 checks passed
@XxFran10xX
XxFran10xX deleted the fix/bronze-model-scheme branch September 27, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant