fix: sync the default model scheme with the live server and add bronze models - #26
Conversation
…e models The bundled basic.yml had drifted from the one TFMCMain01 uses. Its warhammer entries were spelled "warhammher", so warhammers never got a metal model, the steel spear and abyssalite polearm pointed at other metals, and shortsword, lute, shield, banner and the mage scheme were missing. Bronze now uses its own models: the shortsword on iron_sword 49, the lute on iron_shovel 24, and the tfmc_armor bronze armor set. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe basic model schemes correct warhammer identifiers and add weapon mappings. Bronze armor and weapon mappings are updated, a mage armor scheme is added, and wooden material schemes gain shield and banner mappings. ChangesBasic model scheme mappings
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The bundled warhammer mapping now matches its recipe, and no concrete breakage is established for the added mappings. External model assets could not be checked, so their availability remains unverified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the model rows, Comment |
The bundled
model-schemes/basic.ymlhad drifted from the one TFMCMain01 uses. This makes the default match the live file, which now also includes the bronze models.Fixes that were only on live
warhammher, but the recipe type iswarhammer, sogetModelfound nothing and warhammers were crafted without a metal model ("AC: No model in the scheme …").iron_hoe.3(was.2, the iron spear). Abyssalite polearm nowiron_hoe.8(was.9, the mythril polearm).shortswordandlutefor each metal,shieldandbannerfor each wood, and themagescheme.Bronze
iron_hoe.10and polearmiron_hoe.11: its own models (the old default used steel's spear and abyssalite's polearm).iron_sword.49and luteiron_shovel.24: the new bronze models from TF-Minecraft/ServerAssets#19.ia.tfmc_armor:bronze_*: the new bronze armor set (it used steel's).The committed file is byte-identical to
plugins/AdvancedCrafting/model-schemes/basic.ymlon TFMCMain01. The plugin never writesmodel-schemes/itself (it isn't increateConfigs), so servers keep using their own file. This keeps the repo copy, the reference for new setups, in line with the one in use.Tested on TFMCDev01
With this file, admin crafts at a forging station gave a bronze light helmet with the
tfmc_armor:bronze_helmetlook (dye#b38e5d, CMD 10195), a shortsword oniron_swordCMD 49 and a lute oniron_shovelCMD 24.🤖 Generated with Claude Code
Summary by CodeRabbit