Repository navigation
HARP v3.2 - #408
Open
cwitkowitz wants to merge 134 commits into
Open
HARP v3.2#408cwitkowitz wants to merge 134 commits into
cwitkowitz wants to merge 134 commits into
Conversation
… spans the entire application.
Upgraded to latest version of JUCE.
✅ Deploy Preview for harp-plugin-old canceled.
|
Also Increased Size of Buttons
…pdown and number box, updated pyharp to latest develop with corresponding upgrades, cleaned up error popup logic, simplified management of status messages, now hiding sensitive data (e.g. API tokens) from settings and logs, de-duplicated GitHub issue template, file-write logging protections, safe pointers for additional windows, added missing files to CMakeLists.txt, and updated button indexing info in DEVNOTES.md.
…g, handling for too many requests, and added nuance to sleeping / building errors.
…ion of layout organization.
… some sizing and GUI component issues, and fixed some model path bugs.
…JUCE GUI components and fixed scroll capture on FileDisplayComponent.
Model Validation Infrastructure, Script, and Workflow
…wnload error path, graceful handling of empty NumberBox fields, added helper functions to control utilities, removed unused code / paths, and fixed formatting.
Various improvements and bug fixes surrounding error handling and communication.
Update requirements.txt instructions in example.md
…zed files, along with corresponding expect checks.
…#416 review) (#440) * Fix crash and app-hang when closing a tab or quitting mid-request Closing a tab (or quitting the app) while it had an in-flight network request could force-kill a blocked worker thread, corrupting shared networking state and hanging all future model loads. Adds local connection cancellation (RequestRegistry) and defers tab destruction until any in-flight request has actually settled. Found while reviewing PR #416. * Fix six tutorial UI bugs (stuck steps, missing highlights, duplicate tabs, blank tab on finish) - Tutorial steps checked the wrong tab accessor, causing it to appear frozen and never advance - Media Clipboard/Interface Summary steps failed to highlight anything - Interface Summary painted a stray box from an unrelated empty-rect bug - Spam-clicking Next created duplicate tabs (no in-flight-load guard) - Finishing the tutorial reset the auto-loaded tab instead of closing it, leaving it permanently blank Found while reviewing PR #416.
…rument_channel Customize Instrument and Channel for Synthesized MIDI during Model Validation
Fixed merge conflicts related to viewport, tutorial, model paths, and new errors / conventions.
Home Page & Tutorial Refactoring
…arge instruction panel contents, added persistent model card information after loading, and updated authors in headers based on git blame.
Home Page Model Selection, Multiple Tab Support, and Tutorial Refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.