Repository navigation
fix(docs): swap caution and warning admonitions & theme update - #179
Open
wesleyboar wants to merge 7 commits into
Open
wesleyboar wants to merge 7 commits into
wesleyboar wants to merge 7 commits into
Conversation
This was referenced Oct 5, 2026
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Oct 7, 2026
## Overview Swaps admonition `caution` and `warning` styling and demo use-case copy so severity matches typical interpretation. > [!CAUTION] > **Must update all clients, because this is a breaking change** and I don't want to bump major version. ## Related required by: - TACC/mkdocs-tacc#43 - TACC/Core-CMS#1247 - TACC/TACC-Docs#179 - DesignSafe-CI/DS-User-Guide#293 ## Changes - **fixed** `admonition` caution vs warning message-type mapping and icon - **updated** admonition demo `config.yml` use cases - **updated** `dist` build output ## Testing 1. `make start` (or ensure Fractality is on port 3000 with this branch checked out). 2. Open http://127.0.0.1:3000/components/detail/admonition 3. Confirm **Caution** is red (error) and **Warning** is yellow (warning). ## UI | Before | After | | - | - | | <img width="760" alt="Admonition caution and warning (before)" src="https://github.com/user-attachments/assets/16e4cc0f-29df-4cb1-b99f-019deb39c14e" /> | <img width="760" alt="Admonition caution and warning (after)" src="https://github.com/user-attachments/assets/775f0a19-e328-4cf8-9def-d824efa3eb29" /> | Co-authored-by: Cursor <[email protected]>
Preserve on-screen severity after Core-Styles and mkdocs-tacc correct caution vs warning styling. Co-authored-by: Cursor <[email protected]>
wesleyboar
added a commit
to TACC/mkdocs-tacc
that referenced
this pull request
Oct 7, 2026
## Overview Aligns admonition caution/warning styling with Core-Styles and bumps the theme CDN to **2.59.1**. ## Related requires: - TACC/Core-Styles#758 - https://github.com/TACC/Core-Styles/releases/tag/v2.59.1 required by: - TACC/TACC-Docs#179 - DesignSafe-CI/DS-User-Guide#293 ## Changes - **swapped** `pymdownx.css` caution vs warning icons - **updated** CDN pins for `core-styles.base.css` and `core-styles.docs.css` - **swapped** `extensions.md` caution vs warning usage - **updated** theme version to **1.0.5** ## Testing 1. Start server using this branch. 2. Open `/extensions`. 3. Verify admonitions: **caution** red, **warning** yellow. 4. Verify: no other style changes. ## UI | Before | After | | - | - | | <img width="757" alt="Admonition caution and warning (before)" src="https://github.com/user-attachments/assets/e1d64e90-fc74-4b1b-ab55-d9bd2a736547" /> | <img width="757" alt="Admonition caution and warning (after)" src="https://github.com/user-attachments/assets/133be934-a6e6-4544-8ebc-1e2d2603f0d4" /> | --------- Co-authored-by: Cursor <[email protected]>
wesleyboar
force-pushed
the
fix/admonition-caution-warning-swap
branch
from
October 7, 2026 22:29
b0f6037 to
fcba145
Compare
Lock to the published RC with admonition CDN fixes ahead of 1.0.5 stable. Co-authored-by: Cursor <[email protected]>
Refresh lock for RC with Core-Styles 2.59.2 heading fix. Co-authored-by: Cursor <[email protected]>
wesleyboar
marked this pull request as draft
October 8, 2026 03:26
Merge theme lock from chore branch into admonition PR.
Special case: not part of caution/warning swap. Co-authored-by: Cursor <[email protected]>
Member
Author
|
@susanunit, big changes. We should chat first. Not urgent. |
wesleyboar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Important
Swaps
!!! cautionand!!! warningin source text, so red/yellow does not change for user since I swapped the colors in the theme. If author wants the colors to change… I'll undo the text swaps.What? Why?
Admonitions, i.e. —
!!! caution Important text in a box.— were using yellow for caution and red for warning, because of a mistake long ago. I fixed the mistake upstream. To make sure TACC-Docs does not swap colors, I update
!!! cautionto use!!! warning, and vice-versa.Important
Changes link aliases from
https://docs.tacc.utexas.edu/to/, so those links are not interpreted as absolute links be improvement to script that identifies external links._What? Why?
There is a script that identifies external links, then:
That script now interprets
http://andhttps://as external links (because it is simpler, reliable logic) but expects —http://andhttps://for links on the same domain— yet many links to pages on this same docs site are (unnecessarily) using
http://andhttps://.Note
Accesibility changes:
<h1>titles now darker (match body text)Related
Changes
Testing
Admonitions
Start server.
Compare —
— purge policy stays red
Core-Styles 2.37 → 2.59
machine tables,
cmd-line/job-scriptfencesHTML table
rowspanpymdownx
/// tabblocksheading spacing around callouts
UI
Admonitions