Repository navigation
fix(file): clarify discovered parameter shapes and defaults - #342
Merged
Merged
Conversation
This was referenced Oct 20, 2026
# Conflicts: # docs/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #328
What was wrong
The original report's top-level glob guidance was partly fixed already, but discovered file-tool parameter schemas still left fields such as search roots, output modes, sorting, grep patterns and preview flags unexplained. The glob
patternfield only said a positive entry was required, without a quoted JSON-array example.The change
read_filesand the discovery-entry tool unchanged: richer help is paid only after discovery.Validation
Schema/prompt impact: measured compact JSON
{name,description,parameters}with js-tiktoken 1.0.21 / cl100k_base, not provider billing:The real host's resident file+discovery core remains at its existing 242-token gate; the discovery-entry schema remains 95 tokens. Output schemas and model-facing top-level descriptions are unchanged.
Full gate uses the real Landlock backend to keep the unrelated main bwrap-cache defect (#337/#338) separate. No sandbox permission weakening is introduced.
PR-triggered CI: https://github.com/T-Auto/dsh-ops/actions/runs/39479811616 —
pull_request, aggregateCI required: SUCCESS (Windows x64, Linux x64, macOS arm64 and required supporting jobs passed).Environment
Arch Linux x64, Node 24.21.0, Rust 1.97.1; source checkout based on main
a9ff940.Combined local validation
The submitted heads of #338, #340, #341, #342, #343, #344 and #345 were applied together in an isolated local verification worktree, including their combined changelog entries. With ordinary PATH selecting real bwrap 0.13.0 and real dsh-TUI 0.16.1 host/worker/renderer suites enabled,
node scripts/verify-gate.mjs --skip-installpassed all 11 release-gate steps: 129 suites passed, 0 skipped; 46 Rust unit tests passed; manifest 73/59. This Linux combined-tree evidence is separate from each PR's own cross-platform CI; no upstream merge or host installation was performed.