[sarmah-rup]

Changes

Fixes #614.

captureError skipped an error when sampleRate >= Math.random(), so sampleRate: 1 (the default) dropped every automatically captured error and sampleRate: 0 sent all of them. I flipped the comparison so sampleRate is the share of errors that get sent, as the option's doc comment describes. No breaking changes, except that setups which relied on the inverted behaviour will now send the share they asked for.

Testing

Added packages/tracker-js/tests/errorSampling.test.ts. It uses the real Lib with Math.random stubbed and covers rates 1, 0 and 0.2. All 3 fail on main and pass with the fix. The full tracker-js suite passes (11 suites, 89 tests), and tsc --noEmit and prettier are clean.

AI assistance

Claude (Anthropic) helped me trace the bug and write the test. I reviewed the change and ran the tests myself.

Checklist

• Database: no migrations are needed.
• Edition coverage: the tracker script is shared, so this applies to both Cloud and Community Edition.
• Documentation: no changes needed, the docs already describe the correct behaviour.

Summary by CodeRabbit

• Bug Fixes
  • Error sampling now consistently honors the configured sample rate. Errors are sent when the random value is below the rate and dropped when it is equal to or above it. This clarifies the behavior at the sampling threshold, including when the rate is set to 0 or 1.

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: e65bcb51-9ac8-4d71-84ba-41ef1ad352a5

📥 Commits

Reviewing files that changed from the base of the PR and between 321a9ba and eee7091.

📒 Files selected for processing (2)

• packages/tracker-js/src/Lib.ts
• packages/tracker-js/tests/errorSampling.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

captureError now drops errors when the random value is greater than or equal to sampleRate. New tests cover sample rates of 0, 0.2, and 1.

Changes

Error sampling

Layer / File(s)	Summary
Sampling rule and tests packages/tracker-js/src/Lib.ts, packages/tracker-js/tests/errorSampling.test.ts	captureError now drops an error when the random value is greater than or equal to sampleRate. Tests check that rates of 0 and 1 send no errors and all errors, respectively, and that a rate of 0.2 sends at 0.1 but not at 0.9.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: blaumaus

Merge Risk: ⚪ Minimal · up to eee70

Automatic error sampling now follows the configured rate. No merge-blocking issue is identified.

Security Architecture Review

Security architecture risk: 🔵 Low · up to eee70

The fix restores the requested error sampling behavior without changing payload fields, destinations, or callback vetoes. Explicit high sampling rates can now transmit substantially more error data. No introduced vulnerability was established, but server-side handling was not verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The affected client-side scope is error telemetry for configured Lib instances using numeric sampling rates. Higher admitted shares increase transmission of existing error content to the configured endpoint, without adding payload categories or credentials. Receiver-side isolation and effective downstream exposure were not verified.

Trust Boundaries and Controls

• observed — Automatic listener registration still checks disabled tracking, browser context, configured DNT respect, localhost restrictions, and automation detection. Direct captureError calls do not independently repeat that gate, but this predates the PR. Transport still selects the configured apiURL or default host.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the tracker-js error sampleRate fix.
Description check	✅ Passed	The description includes all required sections. It explains the change, reports test results, identifies AI assistance, and completes the checklist with relevant explanations.
Linked Issues check	✅ Passed	Issue #614 requires sampleRate to be the share of automatically captured errors sent, with 1 sending all, 0 sending none, and intermediate rates sampling accordingly. The change makes captureError…
Out of Scope Changes check	✅ Passed	The supplied whole-PR summary identifies a one-line change in Lib.captureError and tests for the sampling behavior in issue #614. Both changes support the linked issue. The summary shows no unrelate…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}