Repository navigation
Route native asset jobs through editor chat without blocking other jobs - #246
Merged
Merged
Conversation
Contributor
Author
|
Engine side update: SummerEngine/SummerEngine#1023 sets SUMMER_EDITOR_CHAT=1 in the desktop agent's runtime, its shell, and (while it still exists) the Summer MCP env. The stacked draft SummerEngine/SummerEngine#1024 removes the Summer MCP from the desktop chat entirely, so once that lands the pin bump of SUMMER_MCP_VERSION is moot and only this PR's CLI gating (the |
The editor's chat generates assets with its own summer_cloud tools, which return at once and post the finished job as a message in the conversation. This package still told that agent "Long work answers with a job: jobs.wait", let summer_call and the direct tools wait on, check and start generation jobs, and the CLI followed jobs with --wait, so the agent waited on jobs the chat already tracks. With SUMMER_EDITOR_CHAT=1 (core/editor-chat.ts): - every MCP instruction string carries the editor chat sentence in place of the job sentence; - tools/call answers jobs.wait, jobs.get and the generation operations (summer_call by op or name, the hosted and 3.x direct tools) at once with an `unsupported` refusal and no hosted call, and tools/list leaves those direct tools out; - summer_search / ops.search and summer ops search leave them out; - summer <area> <action> for those operations, any --wait, and summer tool for those tools exit 1 at once without calling Summer's server. Without the variable nothing changes. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
frozaken
force-pushed
the
claude/editor-chat-no-job-wait
branch
from
November 4, 2026 03:46
2df9fce to
92f89f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Summer's editor delivers native asset-generation results as messages in its chat. The toolkit previously encouraged the agent to start duplicate generation or poll those jobs through MCP or the CLI. With
SUMMER_EDITOR_CHAT=1, this change redirects supported generation to the nativesummer_cloudtools while preserving completion tracking for other work.jobs.getandjobs.waitonly for nativeaj_asset job IDs, includinggen:aj_wrappers. The ID format matches the editor'sequinox_user_events.cppasset-job contract. Ordinarygen:IDs, legacy IDs, builds, uploads, approvals and other job families retain their tracking paths.summer tool, before invoking their handlers.--waitfor supported operations, including builds, approvals and makers. Stop following a chain only when it hands off to a native asset delivery. Print wait instructions only where the command remains usable.1.Rebased onto current main, retaining the startup guidance from #251 and the 4.9.1 changelog entries.
How I tested it
npm test— 3,390 passed, 10 skipped; library validation passed.--wait, job discovery, aliases, argument precedence, native-asset handoff, and unchanged behavior outside editor chat. The narrowed-policy regression tests failed against the original implementation before the fix.npm run buildnpm run generate:registry -- --check— no drift.npm run eval:routing -- --check— no regression.npm run eval:outcomes -- --dry-rununsupported; builds, approvals, makers and ordinary generation jobs reach the normalnot_signed_inpath instead of being rejected by the editor-chat gate. No hosted work was submitted.git diff --checkSuccessful hosted completion is exercised with test doubles, not live paid generation. A graphical editor session was not run. The explicit native-operation list and
aj_ID convention must stay aligned with the engine as its native capabilities evolve.Rollout
Engine PRs SummerEngine/SummerEngine#1023 and #1024 are already merged. The editor sets the flag in the agent's shell; its newer chat no longer mounts Summer MCP, so the CLI path is the primary integration. The MCP handling remains for older integrations that set the flag. This requires a toolkit release and that version being used by the editor's CLI; merging alone does not release it. Outside clients that do not set the flag are unaffected.
Checklist
## [Unreleased]inCHANGELOG.md