feat(sdk): add round-status predicates and human-readable label helper - #227
Open
Olasunkanmi975 wants to merge 2 commits into
Open
feat(sdk): add round-status predicates and human-readable label helper#227Olasunkanmi975 wants to merge 2 commits into
Olasunkanmi975 wants to merge 2 commits into
Conversation
…d comparator Previously a single malformed/non-numeric round entry in .keeper-store.json caused listRounds() ordering (which did BigInt() on the id) to throw, which the load path surfaced as a full corrupted-file backup that dropped every entry. - Drop individual malformed round entries on load instead of nuking the whole store (still warn, still back up on truly corrupted JSON). - Extract a shared compareRoundIds() numeric comparator so listRounds and callers (parseRoundIdSpec) order rounds consistently regardless of id type. Closes Sub-Rosa-Issue#194
Author
|
@karagozemin please review and kindly merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #192: adds pure helpers in the SDK for reasoning about keeper
round statuses without depending on the keeper service.
classifyRoundStatusplusisActiveRoundStatus,isTerminalRoundStatus,isErrorRoundStatuspredicates that partition everyRoundStatusintoexactly one bucket.
roundStatusLabelmapping each status to a human-readable string fordashboards, operator CLIs and alert copy.
isKeeperRoundActive,isKeeperRoundTerminalandisKeeperRoundSettlementPendingoperating onKeeperRoundStatusView.ACTIVE_ROUND_STATUSES,TERMINAL_ROUND_STATUSES,ERROR_ROUND_STATUSES) kept in lockstep withservices/keeper/src/status.ts.Test plan
packages/sdk/src/round-status.test.tscovering classificationpartitioning, label generation and view helpers.
public-api-snapshot.test.tsand the packagetestscript.pnpm test(103 passing) andpnpm typecheckare green.closes #192