fix(keeper): validate store entries on load and extract round-id comparator - #198
Open
Olasunkanmi975 wants to merge 1 commit into
Open
Conversation
…d comparator Previously a single malformed/non-numeric round entry in .keeper-store.json caused listRounds() ordering (which did BigInt() on the id) to throw, which the load path surfaced as a full corrupted-file backup that dropped every entry. - Drop individual malformed round entries on load instead of nuking the whole store (still warn, still back up on truly corrupted JSON). - Extract a shared compareRoundIds() numeric comparator so listRounds and callers (parseRoundIdSpec) order rounds consistently regardless of id type. Closes Sub-Rosa-Issue#194
Author
|
@karagozemin please kindly review and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #194.
The keeper store previously trusted whatever was in
.keeper-store.json. A single malformed or non-numeric round entry would:listRounds()ordering, which didBigInt()directly on the id, andThis change makes load robust and orders rounds consistently.
Changes
services/keeper/src/store.ts): each round entry is validated withnormalizeRoundId; a non-numeric/invalid id (or non-object value) is logged and skipped individually. The whole-file corrupted-JSON backup is preserved for truly unparseable files.compareRoundIds()numeric comparator:listRounds()andparseRoundIdSpec()(inkeeper.ts) now share one comparator so rounds are ordered by numeric value regardless of id type (bigint / number / string).Tests
compareRoundIdsordering across id types.All 70 keeper tests and
tsctypecheck pass.Closes #194