Repository navigation
fix: fix mixture detection when Dominance contains NA - #176
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the statistics refactor (#172),
summary()with several versions can fail with:Error: id variables not found in data: Dominance
stats_pairs()now binds all versions of a situation withbind_rows()before callingformat_cropr()once. Before #172, each version was formatted on its own.When only one version has a
Dominancecolumn on a sole crop (e.g. a previous model version givingDominance = "0"), the bound data hasDominance = c(NA, "0").detect_mixture()countedNAas a distinct value, so it saw two values and treated the situation as an intercrop.format_cropr()then addedDominanceto the columns used to reshape the data. That column was dropped when keeping only the columns shared with the observations, which have noDominance, soreshape2::melt()failed.detect_mixture()now ignoresNAvalues when counting distinctDominancevalues