docs: document customization save lifecycle and fix metered billing race - #1208
Open
darcszn wants to merge 1 commit into
Open
docs: document customization save lifecycle and fix metered billing race#1208darcszn wants to merge 1 commit into
darcszn wants to merge 1 commit into
Conversation
|
@darcszn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The previous
recordUsageconflict fallback read the existing row and then wrotequantity + newQuantityfrom a stale value. When two concurrent calls arrived in the same second, both could read the same pre-update quantity and overwrite each other, causing a lost increment.Changes made
SaveStatetransition model and the public hook contract inuseCustomizationStudio.increment_usage_record_quantityRPC and kept the uniqueness guard in place.Validation
This change was implemented without broad test execution, per the requested scope.
EOF
closes #1008
closes #1139