closes #1164 - #1205
Open
shaarknado wants to merge 1 commit into
Open
Conversation
closes StellerCraft#1164 StellerCraft#1164 Engineer Integration Test Coverage for the Smoke-Test Cron Route Repo Avatar StellerCraft/craft Description apps/backend/src/app/api/cron/smoke-test/route.ts has no integration test file — somewhat ironic for a route whose entire purpose is presumably to validate platform health, since the validator itself is unvalidated by any automated test. Requirements and Context Cover the all-checks-pass success path. Cover at least one individual smoke-check failure, asserting the route reports it clearly rather than masking it as an overall pass. Cover the cron-authentication gate (cron-auth.ts) on this route specifically. Suggested Execution Branch: test/cron-smoke-test-route-integration-coverage Implement Changes Create apps/backend/src/app/api/cron/smoke-test/smoke-test.integration.test.ts. Cover the all-pass, single-check-failure, and cron-auth-gate cases described above. Test and Commit Run npm run test --workspace=@craft/backend -- cron/smoke-test and confirm the new suite passes. Example Commit Message test(backend): add integration coverage for the cron smoke-test route Co-authored-by: <your-name> Guidelines Branch off main, keep PRs focused on one issue All new code must include unit or integration tests Ensure npm run lint and the relevant npm run test workspace pass before review Link this issue in your PR description Request review from at least one maintainer before merging
Author
|
is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1164
closes #1164
#1164 Engineer Integration Test Coverage for the Smoke-Test Cron Route Repo Avatar
StellerCraft/craft
Description
apps/backend/src/app/api/cron/smoke-test/route.ts has no integration test file — somewhat ironic for a route whose entire purpose is presumably to validate platform health, since the validator itself is unvalidated by any automated test.
Requirements and Context
Cover the all-checks-pass success path.
Cover at least one individual smoke-check failure, asserting the route reports it clearly rather than masking it as an overall pass. Cover the cron-authentication gate (cron-auth.ts) on this route specifically. Suggested Execution
Branch: test/cron-smoke-test-route-integration-coverage
Implement Changes
Create apps/backend/src/app/api/cron/smoke-test/smoke-test.integration.test.ts. Cover the all-pass, single-check-failure, and cron-auth-gate cases described above. Test and Commit
Run npm run test --workspace=@craft/backend -- cron/smoke-test and confirm the new suite passes.
Example Commit Message
test(backend): add integration coverage for the cron smoke-test route
Guidelines
Branch off main, keep PRs focused on one issue
All new code must include unit or integration tests Ensure npm run lint and the relevant npm run test workspace pass before review Link this issue in your PR description
Request review from at least one maintainer before merging