fix(backend): update the domain-removal route response to match the c… - #1198
Open
maisamariwanta4-bit wants to merge 1 commit into
Conversation
…orrected aliasesRemoved/aliasesMatched contract - Replace direct VercelService.removeDomain() call with VercelDomainLifecycleService.removeDomainWithCleanup() in the DELETE handler - Surface aliasesMatched (not aliasesRemoved) in the 200 response body, consistent with the RemoveDomainResult interface in the lifecycle service - Include partialFailure / partialFailureReason in the response when alias cleanup encounters errors after the domain has been removed - Update route.test.ts: swap VercelService mock for VercelDomainLifecycleService mock and assert on aliasesMatched in all relevant test cases; add new cases for partialFailure and success:false Closes StellerCraft#1144
|
@maisamariwanta4-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1144
closes #1145
…orrected aliasesRemoved/aliasesMatched contract
Closes #1144