feat(sdk): harden trace IDs, refund grace, preflight, and telemetry s… - #708
Open
spotkorner-dot wants to merge 1 commit into
Open
Conversation
…pans traceId: extract the crypto.randomUUID-preferring generator into a public generateTraceId(), keeping the Math.random UUID v4 fallback for Node < 19. TraceIdManager and existing callers are unchanged. refundGrace: add an optional graceStartedAt anchor to CanRefundOptions and a new applyPartialRefund() that resets the grace countdown to the current timestamp so full-refund eligibility is re-evaluated from the reset point. Grace period duration is untouched; callers that omit the option keep the deadline-based behaviour. preflight: add runPreflight() performing a HEAD probe against the configured RPC URL with a configurable timeout (default 3s) via the existing withTimeout utility, throwing a new PreflightError with URL and reason on failure. telemetry: add an optional parentSpanId to TelemetryEvent plus an active-span stack (startSpan/endSpan/runInSpan). Events inherit the innermost active span ID, or undefined outside any span. Existing consumers are unaffected. Tests added/extended for all four modules (37 passing). Signed-off-by: afurious <[email protected]>
|
@spotkorner-dot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #634
closes #635
closes #636
closes #637
…pans
traceId: extract the crypto.randomUUID-preferring generator into a public generateTraceId(), keeping the Math.random UUID v4 fallback for Node < 19. TraceIdManager and existing callers are unchanged.
refundGrace: add an optional graceStartedAt anchor to CanRefundOptions and a new applyPartialRefund() that resets the grace countdown to the current timestamp so full-refund eligibility is re-evaluated from the reset point. Grace period duration is untouched; callers that omit the option keep the deadline-based behaviour.
preflight: add runPreflight() performing a HEAD probe against the configured RPC URL with a configurable timeout (default 3s) via the existing withTimeout utility, throwing a new PreflightError with URL and reason on failure.
telemetry: add an optional parentSpanId to TelemetryEvent plus an active-span stack (startSpan/endSpan/runInSpan). Events inherit the innermost active span ID, or undefined outside any span. Existing consumers are unaffected.
Tests added/extended for all four modules (37 passing).