refactor: extract pause guard, BPS helper, section comments, expect()… - #652
Open
yahia008 wants to merge 1 commit into
Open
refactor: extract pause guard, BPS helper, section comments, expect()…#652yahia008 wants to merge 1 commit into
yahia008 wants to merge 1 commit into
Conversation
… messages - Stellar-split#626: extract assert_not_paused(env) helper in lib.rs; all entry-point pause checks route through require_not_paused / check_not_paused wrappers - Stellar-split#623: add assert_bps_sum / assert_bps_total to validation.rs; replace inline basis-points sum checks in lib.rs with validation::assert_bps_total; add unit tests for both passing and failing cases - Stellar-split#624: replace all anonymous .unwrap() calls in Invoice::from_compact (types.rs) with descriptive .expect("from_compact: byte N missing") - Stellar-split#625: add section comment headers to StorageKey enum in storage_keys.rs grouping variants by role (Admin, Fees, Pause, Stats, etc.) — no code change
|
@yahia008 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… messages
Closes #626 : extract assert_not_paused(env) helper in lib.rs; all entry-point pause checks route through require_not_paused / check_not_paused wrappers
Closes #623 : add assert_bps_sum / assert_bps_total to validation.rs; replace inline basis-points sum checks in lib.rs with validation::assert_bps_total; add unit tests for both passing and failing cases
Closes #624 : replace all anonymous .unwrap() calls in Invoice::from_compact (types.rs) with descriptive .expect("from_compact: byte N missing")
Closes #625 : add section comment headers to StorageKey enum in storage_keys.rs grouping variants by role (Admin, Fees, Pause, Stats, etc.) — no code change