Fix FeeOptimizer, NotificationCenter, ReminderSender, and CountdownTimer - #652
Open
deeejaymu-afk wants to merge 4 commits into
Open
Fix FeeOptimizer, NotificationCenter, ReminderSender, and CountdownTimer#652deeejaymu-afk wants to merge 4 commits into
deeejaymu-afk wants to merge 4 commits into
Conversation
|
@deeejaymu-afk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@deeejaymu-afk is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix FeeOptimizer, NotificationCenter, ReminderSender, and CountdownTimer
Body
This PR addresses four small UX issues in the invoice components:
FeeOptimizer now shows an "Accept Suggestion" button next to the recommended fee. Clicking it applies the suggested fee (via an
onAcceptFeecallback for callers that manage a transaction fee input, with an internal fallback so the button behaves correctly standalone). The button hides itself once the current fee already matches the suggestion.NotificationCenter already had a "Mark all as read" button; it now performs an optimistic update immediately and awaits persistence, rolling the UI back if persistence fails, matching the "optimistic update + persisted via the notifications API" requirement.
ReminderSender gains an optional "Send at" datetime input. Leaving it empty preserves the existing immediate-send behavior. Choosing a future time enables a "Schedule Reminder" action that stores the scheduled reminder and disables the immediate-send actions; choosing a past time shows an inline validation error.
CountdownTimer (
DeadlineCountdown) already clamped elapsed time at zero and cleared its interval on expiry; it now also accepts a configurableexpiredLabelprop (defaulting to"Expired") instead of a hardcoded string, and stops re-rendering once expired.Closes #629
Closes #630
Closes #631
Closes #632