Skip to content

Fix FeeOptimizer, NotificationCenter, ReminderSender, and CountdownTimer - #652

Open
deeejaymu-afk wants to merge 4 commits into
Stellar-split:mainfrom
deeejaymu-afk:fixes-629-632
Open

Fix FeeOptimizer, NotificationCenter, ReminderSender, and CountdownTimer#652
deeejaymu-afk wants to merge 4 commits into
Stellar-split:mainfrom
deeejaymu-afk:fixes-629-632

Conversation

@deeejaymu-afk

Copy link
Copy Markdown

Title

Fix FeeOptimizer, NotificationCenter, ReminderSender, and CountdownTimer

Body

This PR addresses four small UX issues in the invoice components:

FeeOptimizer now shows an "Accept Suggestion" button next to the recommended fee. Clicking it applies the suggested fee (via an onAcceptFee callback for callers that manage a transaction fee input, with an internal fallback so the button behaves correctly standalone). The button hides itself once the current fee already matches the suggestion.

NotificationCenter already had a "Mark all as read" button; it now performs an optimistic update immediately and awaits persistence, rolling the UI back if persistence fails, matching the "optimistic update + persisted via the notifications API" requirement.

ReminderSender gains an optional "Send at" datetime input. Leaving it empty preserves the existing immediate-send behavior. Choosing a future time enables a "Schedule Reminder" action that stores the scheduled reminder and disables the immediate-send actions; choosing a past time shows an inline validation error.

CountdownTimer (DeadlineCountdown) already clamped elapsed time at zero and cleared its interval on expiry; it now also accepts a configurable expiredLabel prop (defaulting to "Expired") instead of a hardcoded string, and stops re-rendering once expired.

Closes #629
Closes #630
Closes #631
Closes #632

@drips-wave

drips-wave Bot commented Aug 28, 2026

Copy link
Copy Markdown

@deeejaymu-afk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@deeejaymu-afk is attempting to deploy a commit to the kingsman-99's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant