fix: accessibility and component improvements for split-app - #643
Open
okontemple96-dotcom wants to merge 4 commits into
Open
fix: accessibility and component improvements for split-app#643okontemple96-dotcom wants to merge 4 commits into
okontemple96-dotcom wants to merge 4 commits into
Conversation
Adds focus-visible:ring-2 and focus-visible:ring-indigo-500 classes to TextInput component to ensure keyboard-only users can clearly see which field is focused, meeting WCAG 2.1 AA compliance requirements. The focus ring is only visible on keyboard focus (via :focus-visible), not on mouse clicks. Closes Stellar-split#571
Implements toast deduplication in ToastContainer to prevent duplicate toasts when identical events fire within milliseconds. Toasts with the same message and type are now collapsed into a single toast, and subsequent duplicates reset the auto-dismiss timer of the existing toast. Closes Stellar-split#572
Adds comprehensive test coverage for aria-describedby attributes on all FormInputs components (TextInput, NumberInput, Textarea, Select, DatePicker, Toggle, Checkbox). Ensures error and helper text are properly linked to their respective input elements for screen reader users. Closes Stellar-split#570
Adds test coverage for WalletConnect component to ensure it renders an install prompt with a link to the Freighter store when the extension is not detected, rather than showing a blank or non-functional button. Closes Stellar-split#569
|
@okontemple96-dotcom is attempting to deploy a commit to the kingsman-99's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@okontemple96-dotcom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four critical issues across accessibility compliance and component behavior:
aria-describedbyon all error states in FormInputs #570) - Verified proper screen reader text linkingChanges
focus-visible:ring-2to TextInput for keyboard-only usersTest Coverage
All changes include corresponding tests to ensure:
Closes #572
Closes #571
Closes #570
Closes #569