Repository navigation
feat(core): report the conversion formula from the engine - #50
Merged
Merged
Conversation
Stanback
changed the title
The method comparison labelled every Colorado row "fixed turn offset", even for the distance-freestyle rules that only multiply (×1.11 yards to short course, ×1.02 1650 to 1500, ×0.8925 500/1000 to 400/800). Those rows now read "flat multiplier"; rows whose formula adds seconds keep the offset label. Co-Authored-By: Claude Opus 5.5 <[email protected]>
ConversionValue gains `formula`: none, multiplier, multiplier-offset or equivalent. Clients now describe the arithmetic from the engine instead of inferring it from the method, which is how the web labelled Colorado's multiply-only distance rules as a "fixed turn offset". The web comparison and the MCP card render the label from `formulaText` in the shared copy; the card resource moves to 0.3.0-r9. The conformance fixture asserts the formula for same-course, NCAA, Colorado offset and multiply-only cases, and adds a Turnmark Equivalence conversion case. That case exposed test-mcp comparing methodDifferenceSeconds against the first two methods; it now follows the documented rule (NCAA against Colorado, or against Equivalence when selected). Co-Authored-By: Claude Opus 5.5 <[email protected]>
Stanback
force-pushed
the
fix/colorado-formula-label
branch
from
October 24, 2026 20:57
dc712f6 to
ff119d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web method comparison labelled every Colorado Timing row "fixed turn offset". That included the distance-freestyle rules, which only multiply: ×1.11 for yards to short-course meters, ×1.02 for 1650 to 1500, and ×0.8925 for 500/1000 to 400/800. Clients were inferring the arithmetic from the method name.
The engine now reports it.
ConversionValue.formulais one ofnone,multiplier,multiplier-offsetorequivalent. It's set where the engine computes the time, and exposed through Wasm/SDK types and UniFFI.formulaText(value.formula)insrc/lib/calculation-copy.ts. The card resource becomes0.3.0-r9.Tests
formulafor the same-course, NCAA, Colorado-with-offset and Colorado multiply-only cases, and adds a Turnmark Equivalence case. 8,702 cases match in native Rust, Wasm/Node and Wasm/Chromium.test-mcp-uiasserts the card's labels.test-mcpnow computesmethodDifferenceSecondsthe documented way (NCAA against Colorado, or against Equivalence when selected); the new Equivalence case exposed this.ci-changes(81),cargo fmtandcargo clippy -D warningspass.🤖 Generated with Claude Code