Repository navigation
fix(ios): make UI tests pass on iPhone Duo - #49
Merged
Merged
Conversation
reach() searched the wrong list, dragged from places that never scroll, and could dismiss sheets. On a 466x678 display each of these surfaced: - Pick a presented sheet's list by geometry (it starts below the window top); AX order puts it first on the Duo, and the covered converter list can still report itself hittable. - Treat the converter's keyboard toolbar row like the swim editor's: it takes touches across its width, so drags must start above it. - Start drags in the grouped list's side margin; a press-and-drag on a segmented control slides its selection instead of scrolling. - Drag a loaded row by its distance to the visible band instead of flinging, which overshot tall accessibility-size rows on short displays. - Search for an unloaded row until the list stops moving, then reverse, and never drag down at a sheet's top (that dismisses the sheet). - Close Conversion details with tapSheetBar, since the Duo hides a scrolled sheet's navigation bar. - The Duo's display keeps the app portrait when the device rotates; assert a landscape workspace stays expanded only when it is wide. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS UI suite failed 7 of 28 tests on an iPhone Duo simulator, whose short display is 466×678 with a side system rail. The app itself was fine; the failures came from the shared test scroller,
reach(_:in:earlier:), and from sheet toolbars.tapSheetBarscrolls back up until they're available..landscapeLeft. The test now waits for the rotation and checks that the layout is expanded exactly when the screen is wide.Tests: 28/28 pass on both devices.
TURNMARK_IOS_RUNTIME=27.1 node scripts/test-ios.mjs app --device <Duo>TURNMARK_IOS_RUNTIME=26.5 node scripts/test-ios.mjs app --device <iPhone 17>Known gap: on a standard iPhone that failed to rotate, the rotation test would now pass without exercising the wide layout.
🤖 Generated with Claude Code