Repository navigation
fix(mcp): keep close method-spectrum labels apart on the card - #47
Merged
Merged
Conversation
The MCP card had the same collision the web fixed in #46: at phone width the women's 1650 SCY 17:36.20 -> SCM card printed "NCAA" and "Equivalence" over each other. The label layout now lives in src/lib/spectrum-layout.ts and both the web component and the card call it. The card lays labels out after its collapsed details open (a ResizeObserver on the track), dropping a colliding label to a lower row with a leader tick; dots keep their true positions. The card resource moves to ui://turnmark/conversion/0.3.0-r8.html so hosts do not reuse the cached r7 view. test-mcp-ui reproduces the 1650 card at 680px and 390px (it fails on the previous card at 390px), and a unit test covers the shared layout. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46: the MCP card had the same method-spectrum label collision. At phone width, women's 1650 SCY 17:36.20 → SCM printed "NCAA" and "Equivalence" over each other.
src/lib/spectrum-layout.ts. The web component and the card both call it, so they cannot drift.ui://turnmark/conversion/0.3.0-r8.html, so hosts do not reuse the cached r7 view.Tests
test-mcp-uireproduces the 1650 card at 680px and 390px. It fails on the previous card ("Spectrum labels overlap at 390px") and passes now, over both stdio and HTTP.spectrum-layout.test.ts, covers the layout. Vitest passes (191), the existing web spectrum Playwright test passes on desktop and mobile, and svelte-check,ci-changes(81) andtest-mcppass.🤖 Generated with Claude Code