Revert "Make deploy workflow idempotent for PyPI release reruns" - #6
Conversation
审查者指南(小型 PR 中折叠显示)审查者指南通过移除 PyPI 发布重新运行行为的时序图sequenceDiagram
participant GitHubActions
participant PyPI
GitHubActions->>PyPI: Upload package
alt Package version is new
PyPI-->>GitHubActions: Upload succeeds
else Package version already exists
PyPI-->>GitHubActions: Upload fails
end
文件级变更
提示和命令与 Sourcery 交互
自定义你的使用体验访问你的控制面板以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThe deploy workflow is reverted to its previous PyPI publishing behavior by removing Sequence diagram for PyPI release rerun behaviorsequenceDiagram
participant GitHubActions
participant PyPI
GitHubActions->>PyPI: Upload package
alt Package version is new
PyPI-->>GitHubActions: Upload succeeds
else Package version already exists
PyPI-->>GitHubActions: Upload fails
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
🟢 Approval recommended
The workflow change is minimal, YAML-valid, and matches the stated intent to fail on attempts to republish an existing version.
Pull request overview
This PR reverts a previous change to the PyPI publish GitHub Actions workflow, restoring the behavior where publishing fails if the package version already exists on PyPI (i.e., non-idempotent release reruns).
Changes:
- Removed the
skip-existing: trueoption from the PyPI publish action configuration to ensure uploads of an existing version fail.
File summaries
| File | Description |
|---|---|
| .github/workflows/python-publish.yml | Removes skip-existing from the publish step to restore failure-on-duplicate PyPI upload behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sourcery 总结
CI:
Original summary in English
Summary by Sourcery
CI: