Repository navigation
fix: drop the Discord usernames from the roster - #25
Merged
Merged
Conversation
Cards now show the display name and the competitions only. The handle line and its style are gone from the homepage and the team page. The test now asserts no card renders a handle as visible text, so one cannot come back by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roster cards now show the display name and the competitions only. The
roster-handleline and its style are removed from the homepage and the team page.The test asserts no card renders a handle as visible text, so one cannot come back by hand.
Checks:
npm test12/12, a11y audit clean on/team/, screenshot reviewed.Not covered here: the avatar files are still named after the handles, for example
/brand/team/spookymoo.png. Not visible on the page, but a viewer reading the HTML source can still see them.🤖 Generated with Claude Code
https://claude.ai/code/session_014zaBWGWTzWaYuGxr1ro3HM