BED-9713: persist GitHub database IDs for OIDC subjects - #71
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (9)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThe change adds numeric GitHub database IDs to organization and repository resources, models, and graph-node properties. It also separates repository owner node IDs from numeric IDs and qualifies organization role names consistently. ChangesGitHub identity metadata and role naming
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change persists GitHub numeric database IDs for organizations and repositories without replacing existing graph node IDs, enabling immutable OIDC-subject metadata with no identified merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant GitHubRESTAPI
participant OrganizationResource
participant AssetModels
participant GraphNodeProperties
GitHubRESTAPI->>OrganizationResource: Return organization and repository id values
OrganizationResource->>AssetModels: Set database_id fields
AssetModels->>GraphNodeProperties: Propagate database IDs and owner metadata
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 9.52% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 7 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit checks each numeric sign Comment |
Summary
Testing
Dependency
fix/BED-9686-org-role-namingSummary by CodeRabbit
New Features
Documentation