BED-9511: add managed config framework - #81
Conversation
Add a shared managed-mode check and empty mode profiles for future managed collector behavior. ref: BED-9511
Show the unmanaged default explicitly in the BloodHound Enterprise example configuration. ref: BED-9511
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change adds managed-mode configuration helpers, an explicit unmanaged example setting, and tests for defaults, environment values, invalid booleans, and mode-specific default objects. ChangesManaged mode configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds managed-mode configuration plumbing while preserving unmanaged behavior by default. Configuration resolution and validation are covered, and no current merge-blocking production risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit reads each line, Comment |
Summary
Add the configuration foundation for distinguishing managed and unmanaged OpenHound modes. OpenHound remains unmanaged by default, with no mode-specific behavior introduced yet.
Motivation
Resolves: BED-9511
Changes
Caveats
This branch does not add any uses of
is_managed()orget_mode_defaults(). This was deliberate in order to avoid adding unnecessary tech debt, given how early into design and execution we currently are.Testing
Summary by CodeRabbit