fix(registry): lowercase target_hosts_by_hostname lookups - #8
Open
WaiZ0 wants to merge 1 commit into
Open
Conversation
target_hosts_by_hostname is documented and populated as keyed by lowercased canonical hostname (context.py), and mssql.py already looks it up correctly via target.lower(). Five lookups in registry.py looked it up with the target/probe hostname as-is instead, which is whatever case the host was actually discovered in (e.g. LDAP name- pattern matches return the AD computer's own casing, "MECM.sccm.lab"). Two of those five (get_ntlm_settings, get_mssql_settings) index the dict directly and raise KeyError on a case mismatch, killing the entire RemoteRegistry phase for that target -- including the site- code and component-server reads later in the same generator, which are the low-privilege-readable keys that identify a host as an SCCM site server / SQL server. Confirmed against a live lab where a fixed SMB auth bug let RemoteRegistry connect on every host for the first time, and every single one immediately crashed here. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in the same GOAD SCCM lab session as the companion SMB fix
(#7), once that fix let
RemoteRegistry actually connect to every host: the phase then crashed
on every single one instead.
target_hosts_by_hostname is keyed by lowercased hostname (context.py); five
lookups in registry.py used the target/probe hostname as-is instead. Two
index the dict directly and raise KeyError on a case mismatch, killing the
whole RemoteRegistry phase for that host.
Adds a regression test with mismatched casing, which the existing fixture's
always-lowercase TARGET constant could never exercise.