Repository navigation
fix: repeat memoised decoder calls and refuse a thrown call that touched the memo - #489
Merged
Merged
Conversation
…touched the memo A stateful decoder's hit path was never run for a call site seen once, so a hit that throws or returns another value was inlined as the miss value. Each call of a memoised unit now runs twice and must return the same value. A decoder invocation that ends in a throw after it read or stored a memo entry is a state violation, and a violation in the first pass now refuses the unit instead of retrying it with the thrown calls skipped.
…t need the repeat The prefix and miss-result rows are now also caught by the repeated call, so their mutants drop the repeat too.
…the repeated memoised calls
…es with the repeated memoised calls
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F1, F2 and P1 from review r9 (#484's thrown-call retry).
Rows: 7 in obfuscator_sweep_rows.rs, plus 2 ref-repeat rows with a new mutant in decoder_template_sabotage. The full sweep shows no verdict change in either lane. Krunker output is byte-identical in both lanes, and the obfuscator BASELINEs are unchanged.