#821 Migrate PhotoCapture component#840
Merged
Merged
Conversation
This is a first pass towards modernizing this component, but it can still be improved further to use newer Dialog System. The tests were removed because the new form handling relies on ElementInternals api (it was optional before), but it isn't availble in the test environment. Also removed some inline comments about attribution, leaving them here for documentation purposes: > The original code was written by Sir Tim Berners-Lee. It was made into a web component by AI Model GPT-5.4 > > Prompt: Take the code from src/media/media-capture.ts and make it a web component. Make it work in forms as well as not. Make it configurable and follow LoginButton.
This change actually refactors the intended usage of the PhotoCapture component, and gets rid of many features that weren't used or necessary: - Now it only supports the "dialog" mode, this is no longer configurable. - All events have been removed in favour of the native `input` event. This should be fine since the component should be used as a standard FormControl. - Theme configuration has been removed, given that dark mode hasn't been implemented in the Design System yet. Even when it does, it probably should be something that can be changed with a property. - Replaced the standard trigger overriding with a standard trigger slot (also used in LoginButton, LogoutButton, etc.). - Removed some properties that are no longer applicable: `autoCloseOnCapture`, `showTrigger`, `theme`, `presentation`, and `open`.
timea-solid
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.