Repository navigation
Conversation
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a second drag enters while the client is still reading a previous dropped offer, the Enter handler destroys that previous offer. This prevents the client from finishing it after the asynchronous read. The Leave handler already preserves dropped offers and documents that the client owns their final cleanup.
Reuse DataOfferData::leave() when replacing the previous offer. Hover-only offers are still destroyed; dropped offers remain available for the client to finish and destroy. This also records that the old drag has left.
Validation on Linux:
A local isolated Wayland-server regression delays the first transfer, then sends another Enter/Drop before that read completes. With a winit 0.31 client retaining both sessions, the original SCTK code produces only one finish request; this change produces both finish requests and delivers all three test paths. The protocol harness is local validation, not a new test committed in this PR. No application-specific behavior or dependencies are added.