feat: Implement subscription plan templates with dynamic pricing tier… - #1074
Open
Tekgodfrey wants to merge 1 commit into
Open
feat: Implement subscription plan templates with dynamic pricing tier…#1074Tekgodfrey wants to merge 1 commit into
Tekgodfrey wants to merge 1 commit into
Conversation
|
@Tekgodfrey Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s (Issue #921)
Closes #921
Description
This PR integrates the Subscription Plan Templates and Dynamic Pricing Tiers logic, which was previously authored but unlinked across the backend and smart contract layers. Resolves Issue #921.
Key Changes
Smart Contract Integration (
contracts/subscription)TemplateKeyenum and thePlanTemplatevariant toStorageKeyincontracts/types/src/lib.rsto resolve missing type errors.plan_templates.rsmodule insidelib.rsand exposed the following core template functions in theSubTrackrSubscriptioncontract block:create_templatepublish_template_versionset_template_sharedinstantiate_templateget_template,get_owner_templates,get_shared_templates, etc.)get_template_analyticsStorageKeyandSorobanStringinquota.rs,revenue.rs, andgas_storage.rs.Backend Integration (
backend/services/billing)PlanTemplateService, its core methods (validateTiers,validateTemplateDraft,quoteTemplate,resolvePlan), and all associated TypeScript types (PricingTier,PlanTemplate,TemplateOverrides,ResolvedPlan,TemplateAnalytics) fromindex.ts.DynamicPricingStrategywas correctly exported and ready to be injected into thePricingStrategyFactory.Testing & Validation
planTemplateService.test.ts.npm installwas run to ensure dependencies are up-to-date and pass local test hooks.cargo testexecution requires resolving upstreamsoroban-sdktoolchain/workspace issues).