feat: implement generic circuit breaker pattern for external service calls - #1039
Open
menawar wants to merge 1 commit into
Open
feat: implement generic circuit breaker pattern for external service calls#1039menawar wants to merge 1 commit into
menawar wants to merge 1 commit into
Conversation
…calls Closes Smartdevs17#1002 - Implemented a reusable CircuitBreaker utility in both backend (`backend/services/shared`) and frontend (`src/services/network`). - Integrated CircuitBreaker into both backend and frontend `ApiClient`s to provide out-of-the-box resilience against cascading failures. - Added comprehensive unit tests for both implementations with >80% coverage. - Configured frontend circuit breaker to seamlessly integrate with `mobileTracer` for full telemetry on state transitions and fast-failures.
|
@menawar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1002
This PR introduces a generic Circuit Breaker pattern to protect both the backend and frontend systems from cascading failures when calling external services or when the mobile app calls the backend API.
Changes
1. Generic Circuit Breaker Utility
Created a reusable
CircuitBreakerclass in both the backend and frontend environments:backend/services/shared/circuitBreaker.tssrc/services/network/circuitBreaker.tsFeatures:
CircuitOpenError.mobileTracerduring state transitions and fast-fails.2. Integration with API Clients
Integrated the CircuitBreaker natively into our
ApiClients:backend/services/shared/apiClient.ts):src/services/network/apiClient.ts):3. Unit Tests
Added comprehensive test suites for both environments:
backend/services/shared/__tests__/circuitBreaker.test.tssrc/services/network/__tests__/circuitBreaker.test.tsTest Results
Acceptance Criteria