feat: implement webhook signature verification middleware with key rotation - #1038
Open
menawar wants to merge 1 commit into
Open
feat: implement webhook signature verification middleware with key rotation#1038menawar wants to merge 1 commit into
menawar wants to merge 1 commit into
Conversation
…tation Closes Smartdevs17#1001 - Added `createWebhookSignatureMiddleware` in `backend/services/shared` to verify incoming webhook signatures. - Supports dynamically resolving secrets to seamlessly handle key rotation overlaps. - Included comprehensive test suite covering missing headers, raw body handling, valid/invalid signatures, and rotation windows.
|
@menawar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1001
This PR introduces an Express middleware for verifying incoming webhook signatures to enable secure integration with SubTrackr webhooks for both internal microservices and third-party integrators.
Changes
backend/services/shared/webhookSignatureMiddleware.tscreateWebhookSignatureMiddlewarewhich intercepts incoming requests and verifies theirX-SubTrackr-Signatureheader.body-parseraltering whitespace).WebhookSecrets, checking all currently valid secrets within their time windows.sha256=prefix format as well as raw hex formats seamlessly.backend/services/shared/__tests__/webhookSignatureMiddleware.test.tssha256=prefix)backend/services/shared/index.tsTest Results
Acceptance Criteria