fix(pages): drop the trailing dot from static/CNAME - #111
Merged
Merged
Conversation
GitHub Pages rejects "blog.ogenki.io." as a custom domain and silently clears the setting, so the site falls back to smana.github.io and the custom domain starts serving 404s. static/CNAME has carried the trailing dot since the Actions setup in 890318e. The gh-pages copy was corrected by hand in 228d44d, but the source was left alone -- so the very next deploy from main copied the bad value back over the fix and dropped the domain again. Fixing it at the source makes the correction survive future deploys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outage
blog.ogenki.iois currently serving 404 on every path.smana.github.ioserves the site fine, andGET /repos/Smana/smana.github.io/pagesreports"cname": null— GitHub Pages has no custom domain set.Cause
static/CNAMEcontainsblog.ogenki.io.— with a trailing dot. Pages rejects that as a custom domain and silently clears the setting.The dot has been there since
890318e(the original Actions setup). Thegh-pagescopy was corrected by hand in228d44d("Update CNAME", Aug 19), but the source file was never touched — so the next deploy frommaincopied the bad value straight back over the fix.CNAMEbytes228d44d(Aug 19, manual fix)blog.ogenki.io5a5bd14(deploy of7d876fe)blog.ogenki.io.\nFix
Correct
static/CNAMEat the source so the fix survives future deploys. The file is now byte-identical to the working228d44dversion (14 bytes, no trailing dot, no newline), andhugo --minifyemits it verbatim topublic/CNAME.Note: merging this is not sufficient on its own
Pages has already cleared the custom domain. Deploying a correct
CNAMEfile should re-establish it, but if it does not, the domain has to be re-set once in Settings → Pages → Custom domain (blog.ogenki.io), after which this fix keeps it from being clobbered again.