Repository navigation
fix(sync): keep fork-generated files on merge conflict (sync failing since Oct 6) - #58
Conversation
Upstream cursor/plugins now ships its own .claude-plugin/marketplace.json (origin-apps), which add/add-conflicts with this fork's generated one. The conflict handler rebuilt README.md before that conflict was resolved, so rebuild-readme.mjs crashed parsing conflict markers and every daily sync has failed since 2026-10-06. Resolve marketplace.json and README.md with --ours; the existing "Sync manifests" and "Rebuild README" steps regenerate both from the merged tree. Taking upstream's marketplace.json would also have renamed the marketplace from cursor-plugins-claude to cursor-plugins. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks, this landed on main through #59, which folded it in alongside the agent frontmatter change, so GitHub shows this PR as merged. The merge kept your commit (1ca4787) and its authorship. While testing the fixed sync against current upstream, a second blocker turned up: upstream's 182f2ce changes Your branch has not been touched. |
Every scheduled Sync upstream run since 2026-10-06 has failed. The last one that succeeded was #57 on 2026-10-05.
mainis now about 119 commits behindcursor/plugins.Cause
cursor/pluginsnow ships its own.claude-plugin/marketplace.json. It lists one plugin,origin-apps. When the workflow mergesupstream/main, that file add/add-conflicts with this fork's generated marketplace, andREADME.mdconflicts as well. The conflict handler then:README.mdand runsscripts/rebuild-readme.mjswhilemarketplace.jsonis still unresolved, so the script crashes:marketplace.jsoneven if step 1 got through. That would rename the marketplace fromcursor-plugins-claudetocursor-pluginsand keep upstream's one-entry plugin list, so existing/plugin install …@cursor-plugins-claudeinstalls would break.Fix
The fork generates both files, so resolve them with
--ours. The existing Sync manifests and Rebuild README steps then regenerate them from the merged tree. Every other conflicted file still resolves in favor of upstream, as before.Testing
I ran the patched step against
mainmerged with the currentupstream/main(f713f14):sync-manifests.mjsreports17 plugins (+0 -0)and picks uporigin-apps. The marketplace name stayscursor-plugins-claude.rebuild-readme.mjslists 17 pluginsvalidate-plugins.mjs: "All plugins validated successfully."I'm sending this as a PR because Issues and Discussions are turned off on this repo.
🤖 Generated with Claude Code