Repository navigation
Write down what the gate turned up: the compressor makes ramps - #7
Merged
Merged
Conversation
Verifying the wind gate on a real rebuild produced the opposite of what the simulation predicted. The Rebel Moon cut came out less silent with the gate on than the score it replaced, 11 per cent against 28.6, and at a gate of 1.0, with the camera contributing nothing at all, it was still 10.7. That last number is what settled it: whatever was keeping the fan on, it was not the camera and it was not the wind model. It is compress(). It drops a point when it is within --threshold of the last kept one, which is a fine rule for noticing change and the wrong one for a series read back by linear interpolation. A long flat stretch is dropped whole, so nothing holds the flat value just before a step, and the reader slides from the last kept point all the way up to it. hack/windramp.py is the smallest case: 100 seconds of silence, then a four second gust at 0.55. 496 frames become 4 points, and a fan that should blow for 4 seconds blows for 94. This was invisible until now because the old wind signal was smooth and continuous, which is the one shape this compressor handles correctly. The gate produces hard steps, and every step grew a ramp in front of it. It applies to every curve in every score, not only wind. scenes.snap is already a partial fix for exactly this at scene cuts. The general fix is the same move applied everywhere, and it changes every curve in every score, so it is filed rather than taken: it wants its own pass, a before-and-after on a real film, and a decision about what it does to score size. Nothing was left rebuilt. The cut is back to the score it had and the gate is back at its default; both feature scores are untouched and still the ones from 2026-08-31. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying the wind gate on a real rebuild produced the opposite of the predicted result, and the cause is not the wind model.
compress()drops a point when it is within threshold of the last kept one, so a long flat stretch is dropped whole and linear interpolation ramps from the last kept point up to the next step.hack/windramp.pyis the smallest case: a four second gust becomes 94 seconds of fan. It affects every curve in every score. Filed rather than fixed, because the fix changes every curve in every score and wants its own pass.🤖 Generated with Claude Code