Load every projection of a field - #1414
Merged
Merged
Conversation
Setting a projection on a field replaced the one already there, so a field given two loaded only the last one's data. Whatever the first asked for was read from the entity as its default value. WithProjection now adds to a field's projections rather than replacing, and all of them are loaded. A field can be built from several parts, each saying what it reads: a downstream API has a permission field with one projection for its rights check and another for its allow check, and the check whose column went unloaded silently answered for every row it should have denied. The field keeps a list of projections, and the paths of all of them are analyzed together, once, as before. The first projection still gives the primary root, so a field with one behaves as it did. A path both projections read is added once. Version 35.3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a projection on a field replaced the one already there, so a field given two loaded only the last one's data. Whatever the first asked for was read from the entity as its default value.
WithProjection now adds to a field's projections rather than replacing, and all of them are loaded. A field can be built from several parts, each saying what it reads: a downstream API has a permission field with one projection for its rights check and another for its allow check, and the check whose column went unloaded silently answered for every row it should have denied.
The field keeps a list of projections, and the paths of all of them are analyzed together, once, as before. The first projection still gives the primary root, so a field with one behaves as it did. A path both projections read is added once.
Version 35.3.0.