Repository navigation
Conversation
🤖 CI reportℹ️ MCP UI apps size — 34 app(s), 27969.1 KB JSBuilt size of each MCP UI app (
ℹ️ MCP agent API — agent-facing tool changesWhat this PR changes for agents, from the tool schema snapshots and tool definitions. Tools changed (1):
|
Silthus
force-pushed
the
email-v2/06-template-editor
branch
from
October 25, 2026 14:59
bb9ed7b to
4117342
Compare
Silthus
force-pushed
the
email-v2/08-admission-checks-django
branch
from
October 25, 2026 15:00
49cab17 to
24881fa
Compare
Silthus
force-pushed
the
email-v2/06-template-editor
branch
from
October 25, 2026 17:38
4117342 to
dc7683f
Compare
Silthus
force-pushed
the
email-v2/08-admission-checks-django
branch
from
October 25, 2026 17:38
24881fa to
801bdfc
Compare
Silthus
force-pushed
the
email-v2/06-template-editor
branch
from
October 25, 2026 22:27
dc7683f to
d321dd8
Compare
Silthus
force-pushed
the
email-v2/08-admission-checks-django
branch
from
October 25, 2026 22:28
a5d494f to
1d7fe4c
Compare
Silthus
force-pushed
the
email-v2/06-template-editor
branch
from
October 26, 2026 01:11
d321dd8 to
6730e40
Compare
Silthus
force-pushed
the
email-v2/08-admission-checks-django
branch
from
October 26, 2026 01:11
1d7fe4c to
0eeb308
Compare
Silthus
force-pushed
the
email-v2/06-template-editor
branch
from
October 26, 2026 02:34
6730e40 to
d3da69f
Compare
Silthus
force-pushed
the
email-v2/08-admission-checks-django
branch
2 times, most recently
from
October 26, 2026 05:29
25f064a to
0f434a3
Compare
Silthus
force-pushed
the
email-v2/06-template-editor
branch
from
October 31, 2026 12:51
2332fd3 to
72e6cf9
Compare
Silthus
force-pushed
the
email-v2/08-admission-checks-django
branch
from
October 31, 2026 13:47
0f434a3 to
f3b92ce
Compare
A code send, or a send by `template.key`, that names a `from` on no verified domain now answers `sender_not_verified` with `attr: "from"`, so an SDK can show which field to fix. A send without `from` whose project has no verified default sender still names no field. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Silthus
force-pushed
the
email-v2/06-template-editor
branch
from
October 31, 2026 16:05
7b2198c to
1390333
Compare
Silthus
force-pushed
the
email-v2/08-admission-checks-django
branch
from
October 31, 2026 16:09
f3b92ce to
1c8455d
Compare
…-checks-django # Conflicts: # products/messaging/backend/tests/api/test_transactional_email.py
… every send refusal Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…-checks-django Co-Authored-By: Claude Opus 5.5 <[email protected]>
…-checks-django Co-Authored-By: Claude Opus 5.5 <[email protected]>
…-checks-django Co-Authored-By: Claude Opus 5.5 <[email protected]>
…-checks-django Co-Authored-By: Claude Opus 5.5 <[email protected]>
Owner
Author
|
Moved to PostHog#127181. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the code-first rebuild of the email send stack; replaces parts of PostHog#121850 (refuse a send the send checks would skip).
Problem
fromthat no verified sender covers gets400 sender_not_verifiedwithattr: null. The answer does not say which field to fix.attrto the field in error has nothing to point at. The same code without afrommeans the project has no default sender, a different fix.Impact
Pays into Grow Workflows through billed
workflows_emailsactions per paying org: a developer fixes the right field on the first refused send. In scope: Messaging, email API sends.Merge Danger
Note
🟢 Merge risk: low · two-way door: a revert answers
attr: nullagainattrof one refusal changes, onsend/email/, behindworkflows-email-from-code. The code, status and detail stay the same.from.Changes
fromno verified sender covers answerssender_not_verifiedwithattr: "from". That holds for a code send and for a send bytemplate.key.fromon a project with no verified default sender keepsattr: null, since the caller sent no field to fix.TransactionalEmailRejectedpath and the{type, code, detail, attr}shape, withtype: invalid_requestand the status from master's code map.TransactionalEmailRejectedsubclasses DRF'sValidationError, soexceptions_hogreads its field. A dict detail on a plainAPIExceptionanswers500there.PIPELINE_REFUSALSdecoder for cdp-api's answers stays as it is on master.How did you test this code?
Test seams:
send/email/through the DRF client with cdp-api mocked (test_transactional_email.py).Test rationale:
attr: "from"for a key send with an unverifiedfrom. It caught thenullbefore the fix.fromon a project with no default sender answersattr: null. Without it, a class that always namesfromwould pass.type,codeandattr: a refusal that turns intovalidation_error, or skips the status map, fails them.Proofs on this head
c8a4107(saved withfleet proof):f9abed0, maildev as the sink. 21 requests through the public API. A code send from an unverified domain answers400with{"type": "invalid_request", "code": "sender_not_verified", "attr": "from"}and sends nothing.Earlier live run, 2026-10-31
Live run, 2026-10-31. Django at the top of the stack (
3a30f51c529), cdp-api and both CDP workers at feat(cdp): send a template from the workflow version Django graded #584 (f9abed0841c), mail caught in maildev.sender_not_verified,attr: "from", nothing senttemplate.keyfrom an unverified domainsender_not_verified,attr: "from", nothing sentfromfieldProd shape: a gap until read-only production access exists on 2026-11-02.
CI: the fork has no Depot runners, so those jobs never start.
Semgrep Checks Passfails on every fork PR, because its path filter job runs only for the PostHog owner; semgrep with the repo's rules passes locally on the changed files. The lane check reportscross_lane=false.Release status
Docs update
None.
🤖 Agent context
Autonomy: Human-driven (agent-assisted)
Agent: Claude Code, Claude Opus 5.5 (claude-opus-5-5)
dj3of map Map: send code-managed email templates with one PostHog call #461 onto master's refusal code, on feat(workflows): show code-managed email templates read-only #575 at7b2198c. One GPT-6.1 Sol review round; both findings rejected with reasons in the ledger.qa-swarm,modernize-pr,tdd,writing-tests,improving-drf-endpoints,pr-description,writing-pr-descriptions.PIPELINE_REFUSALSdecodersender_not_allowed?attr: "from"versusattr: nulltells the two cases apart, and no client reads a second codeInvolvement: one brief with Michael's shrink decision; one review round (GPT-6.1 Sol) answered; QA swarm on 2026-11-01 with two panel rounds (GPT-6.1 Sol review, Opus 5.5 fresh eyes) and two final reads, the last clean: 2 findings fixed, none rejected; live run captured.
🤖 Generated with Claude Code