fix: align sitemap routes with canonical intent - #50
Merged
Conversation
Closes #47 Issue #47: the live sitemap listed /faq and /login with the homepage canonical. The runtime fixes (self-canonical for /faq, /login removed from the sitemap, noindex on /login) shipped in #48. This adds the missing regression guard so the parity cannot silently regress: - For every URL in public/sitemap.xml, resolve its landing-astro source page and assert it declares a self-canonical (canonicalPath == its own pathname). The homepage keeps the Layout default '/'. - Assert /login never re-enters the sitemap. - Reuses the existing sitemapUrls() helper and AGENT_SURFACE catalog.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
reader | 611d9da | Aug 14 2026, 11:25 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Problem
The live sitemap listed
/faqand/loginwith the homepage canonical (full production crawl on 2026-08-14: 4 direct-200 sitemap URLs, 2 canonical mismatches).What changed
The runtime fixes shipped in #48:
/faqgot an explicit self-canonical (canonicalPath="/faq")./loginwas removed frompublic/sitemap.xml(it is an account route, not a public content page) and givenX-Robots-Tag: noindex, follow.This PR adds the missing regression check for sitemap/canonical parity so the fix cannot silently regress:
public/sitemap.xml, resolve itslanding-astrosource page and assert it declares a self-canonical (canonicalPath== its own pathname). The homepage keeps the Layout default/./loginnever re-enters the sitemap.sitemapUrls()helper andAGENT_SURFACEcatalog.Verification
pnpm test— 97 passed (includes the new parity test).pnpm quality— lint 0 errors, typecheck, build, and hygiene all green.Constraints honored
/loginstays out of the sitemap;/faqkeeps its self-canonical.