Repository navigation
Interview-readiness fixes - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Interview-readiness corrections from an independent audit. Committed benchmark metric values, train selections, and thresholds are unchanged except where a step below adds an optional field or changes which frozen config the CI gate runs.
benchmarks/pytest-junit.xml,benchmarks/test-coverage.json, and the unusedrequirements/constraints-py312.txtare removed.docs/results.md. Table regions in both files are rendered and drift-checked. Acronyms are defined on first use. Ragas, DeepEval, promptfoo, and ARES have citation links.configs/scifact-bm25.yamlis no longer the gate. Hybrid stays out of the main job because it needs the dense extra.pytrec_evalis an optionalagreementextra. The agreement test skips without it. The Linux CI job installs g++ and that extra. Install instructions areuvonly.ragstat.__version__comes from package metadata. Rerankindex_msexcludes model loading.CITATION.cffis added.Test plan
ruff check,ruff format --check,mypypytestwith coverage, gated extras only (no dense, no agreement)README.mdanddocs/results.mdbenchmarks/baseline.json(shared non-timing fields)docker buildanddocker runuv sync --frozen --extra dev --extra apiwithout buildingpytrec_eval