Repository navigation
Fix stale proxmox_write_file size hints (45 KiB, not 1 MB) - #54
Merged
Merged
Conversation
The agent write cap is 45 KiB since the file-write fix; two hints in the upload path still said 1 MB. Found while live-testing on a QEMU VM. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HpjwiAg4NUssQYBz8D8Rbz
Showdown76py
approved these changes
Oct 11, 2026
Showdown76py
left a comment
Showdown76py
left a comment
Owner
There was a problem hiding this comment.
LGTM 👍 Both hints now match _FILE_WRITE_MAX_BYTES. The remaining 1 MB mentions are about the read path, where 1 MB is still the right cap. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two hints in the upload path still said
proxmox_write_filetakes up to 1 MB. The real cap is 45 KiB (_FILE_WRITE_MAX_BYTES). Only text changes, no behaviour change.Found while live-testing the QEMU paths on pve1 with a temporary Debian 12 VM. All 13 checks passed:
The VM and its temp config were removed afterwards.
Tests: 707 passed locally, ruff clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HpjwiAg4NUssQYBz8D8Rbz
Generated by Claude Code