Repository navigation
fix: review notes on #52 - #53
Merged
Merged
Conversation
- Legacy file-read fallback drops `count` too: it may be as new as `decode`, and the length check still enforces the limit. - proxmox_fetch_url tries every checked address, not only the first. - A write dropped mid-request is no longer reported as a timeout. - Comment on the private httpx `_pool` hook and the versions it was checked against. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01HpjwiAg4NUssQYBz8D8Rbz
Ailcope
changed the title
Ailcope
changed the title
Owner
|
LGTM 👍 All four notes from #52 are addressed, each with its own test. Good to merge once the test jobs are green. |
Showdown76py
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your four notes on #52, which merged without them. Now a single commit on top of main.
countas well asdecode. Thelen(data)check still enforces the limit._GuardedNetworkBackend.connect_tcp: tries every checked address in turn instead of onlyaddrs[0]._fetch_transport: comment on the private_poolhook and the httpx/httpcore versions it was checked against.Each change has a test that fails without it. Full suite: 707 passed, ruff clean.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HpjwiAg4NUssQYBz8D8Rbz