Skip to content

Accept canonical app block paths in block tags - #1282

Open
richpoirier wants to merge 1 commit into
Shopify:mainfrom
richpoirier:rich/liquid-parser-app-block-paths
Open

richpoirier wants to merge 1 commit into
Shopify:mainfrom
richpoirier:rich/liquid-parser-app-block-paths

Conversation

@richpoirier

@richpoirier richpoirier commented Aug 20, 2026 •

Copy link
Copy Markdown

What are you adding in this PR?

Theme Check reports a LiquidHTMLSyntaxError for canonical inline app block paths. This change accepts shopify://apps/<app>/blocks/<handle>/<uuid> values in block tags while preserving errors for malformed paths and existing invalid block types.

It also removes duplicate block-name validation from LiquidSyntaxError. The parser now owns block-name validation, so successfully parsed BlockMarkup values are not rejected by a second validator.

App blocks render with the settings their app provides, so LiquidSyntaxError now reports arguments and content on app block paths. This applies to plain arguments and to the block.settings.<id> form. block.name stays allowed. The block parameter checks from #1306 do not report anything for app block paths, because no blocks/*.liquid file exists for them.

{% block 'shopify://apps/example_app/blocks/example-block/00000000-0000-4000-8000-000000000000' %}{% endblock %}                  {% # ok %}
{% block 'shopify://apps/example_app/blocks/example-block/00000000-0000-4000-8000-000000000000', heading: 'Hi' %}{% endblock %}   {% # app blocks do not accept arguments %}
{% block 'shopify://apps/example_app/blocks/example-block/00000000-0000-4000-8000-000000000000' %}Hi{% endblock %}                {% # app blocks do not accept content %}
{% block 'shopify://apps/example_app/snippets/example-block/00000000-0000-4000-8000-000000000000' %}{% endblock %}                {% # not a valid block type %}

Rebased onto #1306 and added a changeset.

@richpoirier
richpoirier force-pushed the rich/liquid-parser-app-block-paths branch 4 times, most recently from 34950e0 to 0caa5d4 Compare August 20, 2026 15:47
@richpoirier
richpoirier marked this pull request as ready for review August 20, 2026 19:25
@richpoirier
richpoirier requested a review from a team as a code owner August 20, 2026 19:25
@richpoirier
richpoirier force-pushed the rich/liquid-parser-app-block-paths branch 2 times, most recently from 2a5f003 to 6342c7a Compare August 20, 2026 21:11

@charlespwd charlespwd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changeset. Rest of PR looks good to me.

@richpoirier
richpoirier force-pushed the rich/liquid-parser-app-block-paths branch from 6342c7a to f6f648c Compare September 29, 2026 20:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants