Make comment continuation on type formatting configurable#4163
Open
AboodFares wants to merge 1 commit into
Open
Make comment continuation on type formatting configurable#4163AboodFares wants to merge 1 commit into
AboodFares wants to merge 1 commit into
Conversation
Adds a new onTypeFormatting entry to featuresConfiguration, with a commentContinuation option (enabled by default). When disabled, breaking a line inside a comment no longer inserts a leading # on the next line. Closes Shopify#4152
AboodFares
force-pushed
the
make-comment-continuation-configurable
branch
from
July 19, 2026 03:11
18168af to
a97e842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4152
Adds a new
onTypeFormattingentry tofeaturesConfigurationwith acommentContinuationoption (enabled by default). When disabled, breaking a line inside a comment no longer inserts a leading#on the next line.GlobalState, passed by the server into theOnTypeFormattingrequestrubyLsp.featuresConfiguration.onTypeFormatting.commentContinuationsetting (forwarded automatically as an initialization option, so any editor can configure it)