Repository navigation
fix(theme): make templates pass strict Liquid validation - #25
Draft
EvilGenius13 wants to merge 1 commit into
Draft
EvilGenius13 wants to merge 1 commit into
EvilGenius13 wants to merge 1 commit into
Conversation
EvilGenius13
force-pushed
the
fix/strict-liquid-templates
branch
from
September 30, 2026 19:22
5b0860e to
2df097b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Shopify rejects this theme on strict-Liquid stores with three errors.
layout/theme.liquidcompares insideassign should_redirect = template != blank,templates/gift_card.liquidnests{{ }}inside quoted strings for the title and remaining balance, andtemplates/list_collections.jsonfails with "Template type 'list_collections' does not support JSON templates". The Vibe and WordPress redirect themes are built from this repo'svibe-redirect-themeandwordpress-sales-channelbranches and install on about 1,000 new shops a day, so as strict parsing rolls out, those installs depend on the platform rewriting these files.should_redirectis now set inside anif template != blankblock, which keeps the original intent. The two broken gift card strings and the Apple Wallet alt text are now plain English, like the rest of the template, which the original author converted from Dawn's translation keys to English in 2022. There is no locale file because adding any*.default.jsonmakes core treat the theme as supporting only English, and a main theme then resets a non-English shop's primary locale toen. The JSON template is renamed tolist-collections.json, the name Shopify uses. One extra line: the "Continue shopping" link now checksstorefront_hostname != blank, because an empty setting counted as true and renderedhref="https://".After this merges, the same commit goes onto
vibe-redirect-themeandwordpress-sales-channel, where it cherry-picks cleanly, and both zips get republished through Shopify/static-cdn-assets.🎩 Tophat it
You need a dev store with strict Liquid enabled. The redirect itself was checked with local renders, not on a live storefront.
mainfails with the three errors above./gift_cards/[store_id]/previewwhile the dev server runs. The page title reads "Here's your $100 gift card for" followed by the shop name.