Repository navigation
DEV-1372: HIL counts an SD logging start from the unit's confirmation too - #144
Merged
Merged
Conversation
… too midStreamSet failed on a Shimmer3 over Classic with about 2.3% of packets lost "away from SD logging start/stop". The loss was the unit's own pause while it opens its file after a logging start. The last packet before that pause arrives 0.35-0.71 s after the unit confirms the start, but on the first start that is up to 1.17 s after the command. The harness measured only from the command, with a 1 s window, so it charged the pause to the Android API. midStreamSet and inStream now also mark the moment the unit confirms a start. Replaying the attribution on the eight recorded Shimmer3 runs that really logged reproduces the three failures (2.289%, 2.362%, 1.226%), and with the confirmation counted, none of the eight has any loss left away from the transitions. The README says so. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure
The Android HIL gate on master failed
midStreamSeton a Shimmer3 over Classic: about 2.3% of packets lost "away from SD logging start/stop", against a 1% limit.That loss is the unit's, not the Android API's:
Times are to the last packet before the pause, from the eight recorded Shimmer3 runs that really logged (three starts each):
The change
midStreamSetandinStreamalso mark the moment the unit confirms each logging start, so the 1 s window runs from the confirmation as well as from the command. Nothing else about the attribution changes: same window, same nearest-command rule, and loss near a battery read or anywhere else still fails.Testing
StreamAnalysis.attributedoes it, on the samples and events of the eight recorded Shimmer3midStreamSetruns that really logged.:shimmerHilTest:compileDebugAndroidTestJavaWithJavacand:shimmerHilTest:testDebugUnitTestpass.midStreamSeton the same Shimmer3 over Classic passed. 242 packets went missing, all within the logging windows, and none elsewhere. The first-start pause was 143 packets, starting 0.71 s after the unit confirmed the start and 1.27 s after the command, so the old harness would have failed this run too.🤖 Generated with Claude Code