Repository navigation
Build against Shimmer Java API 0.11.12_beta by default - #142
Merged
Merged
Conversation
Moves the default driver version in ShimmerAndroidInstrumentDriver/build.gradle from 0.11.11_beta to 0.11.12_beta. Opened by ShimmerResearch/Shimmer-Java-Android-API's Release workflow for API_v0.11.12_beta (26ae4e74c2064453db956e209217fdcf2d21aec3).
Driver 0.11.12_beta no longer writes the clock to a streaming Shimmer3R (Shimmer-Java-Android-API#339), so startSDLogging() on one queues only START_LOGGING_ONLY_COMMAND. The three tests expected SET_RWC_COMMAND first. As #339 did for the driver's own tests, they now put START_LOGGING_ONLY in flight. Where a test needs a command queued behind it, they use readDirectoryName(): while streaming, readBattery() here writes straight to the socket rather than queueing. AGENTS.md records the case as done. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the default driver version in
ShimmerAndroidInstrumentDriver/build.gradlefrom 0.11.11_beta to 0.11.12_beta, released as API_v0.11.12_beta. CI and local builds use the default. Release Android API builds against the newest Java release whether or not this merges, so this PR is the check that the library and the examples still work with it.Before merging:
Shimmer.javahas its own copy of that parser, so those fixes never reach it through this pin: port each one by hand. AGENTS.md explains why (DEV-1148 ported DEV-1147's fix).After merging:
tools/hil/run-android-hil.ps1 -Report -DriverVersion 0.11.12_beta. Theandroid-hil (driver 0.11.12_beta)status it posts is per commit, so a run on this branch does not count for the release.driver_version0.11.12_beta, or blank for the newest Java release.Opened by the Release Java API run.