Skip to content

DEV-1359: CI runs the library's unit tests - #141

Merged
JongChern merged 1 commit into
masterfrom
DEV-1359_ci_unit_tests
Oct 29, 2026
Merged

JongChern merged 1 commit into
masterfrom
DEV-1359_ci_unit_tests

Conversation

@JongChern

@JongChern JongChern commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What

ci.yml built the library and every example but ran no tests. Each Java API release will now open a PR here that moves the default driver version (Shimmer-Java-Android-API's update-android job, in its companion PR), and that PR should run the unit tests too.

  • New step Run the library's unit tests: ./gradlew :ShimmerAndroidInstrumentDriver:testDebugUnitTest, with the same -P/-D flags as the build step. It runs after the build, and also when an example failed to build, so one run reports both. Debug variant only, since the release variant runs the same tests.
  • Job renamed from "Build library and examples" to Build and test. No check is required to merge here (the master ruleset has none), so nothing depends on the old name.
  • AGENTS.md: the "No CI" section was out of date since ci.yml landed, so it is replaced. It also says CI runs the unit tests and that the default driver now moves through the Java release's bump PR. And it notes that some tests check what the driver queues, so a driver bump can fail them with nothing wrong here (below).

Tested

  • On master at the current pin (0.11.11_beta), locally: testDebugUnitTest passes all 26 tests (AAPI_00002: 10, 00003: 4, 00004: 3, 00005: 6, 00006: 3).
  • This PR's own CI run is the first run of the new step on GitHub.

Known consequence: the next driver bump will fail three tests

The next Java API release will include DEV-1337 (ShimmerResearch/Shimmer-Java-Android-API#339, still open): the driver will no longer write the clock (SET_RWC) to a streaming Shimmer3R. AAPI_00002, AAPI_00003 and AAPI_00005 expect startSDLogging() on a streaming Shimmer3R to queue SET_RWC_COMMAND, so they will fail on that release's bump PR until they are adapted. #339 adapted the driver's API_00027, API_00030 and API_00032 the same way. This PR does not change them.

Companion: ShimmerResearch/Shimmer-Java-Android-API#341 adds the update-android job that opens the bump PRs. It needs a new ANDROID_REPO_TOKEN secret in that repo; this PR needs nothing added.

🤖 Generated with Claude Code

ci.yml built the library and the examples but ran no tests, so a driver
pin bump PR (which each Java API release now opens, DEV-1359) never ran
AAPI_00002 onwards. A new step runs :ShimmerAndroidInstrumentDriver:
testDebugUnitTest with the same flags, after the build, and also when an
example failed to build so one run reports both. The job is renamed
"Build and test"; no check is required to merge, so nothing depends on
the old name.

AGENTS.md: replace the stale "No CI" section, say CI runs the unit tests,
that the default driver now moves through the Java release's bump PR, and
that some tests assert what the driver queues, so a bump can fail them
(DEV-1337 will, for AAPI_00002, 00003 and 00005).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@JongChern
JongChern merged commit e3e10ac into master Oct 29, 2026
1 check passed
@JongChern
JongChern deleted the DEV-1359_ci_unit_tests branch October 29, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant