Repository navigation
DEV-1359: CI runs the library's unit tests - #141
Merged
Merged
Conversation
ci.yml built the library and the examples but ran no tests, so a driver pin bump PR (which each Java API release now opens, DEV-1359) never ran AAPI_00002 onwards. A new step runs :ShimmerAndroidInstrumentDriver: testDebugUnitTest with the same flags, after the build, and also when an example failed to build so one run reports both. The job is renamed "Build and test"; no check is required to merge, so nothing depends on the old name. AGENTS.md: replace the stale "No CI" section, say CI runs the unit tests, that the default driver now moves through the Java release's bump PR, and that some tests assert what the driver queues, so a bump can fail them (DEV-1337 will, for AAPI_00002, 00003 and 00005). Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ci.ymlbuilt the library and every example but ran no tests. Each Java API release will now open a PR here that moves the default driver version (Shimmer-Java-Android-API'supdate-androidjob, in its companion PR), and that PR should run the unit tests too../gradlew :ShimmerAndroidInstrumentDriver:testDebugUnitTest, with the same-P/-Dflags as the build step. It runs after the build, and also when an example failed to build, so one run reports both. Debug variant only, since the release variant runs the same tests.AGENTS.md: the "No CI" section was out of date sinceci.ymllanded, so it is replaced. It also says CI runs the unit tests and that the default driver now moves through the Java release's bump PR. And it notes that some tests check what the driver queues, so a driver bump can fail them with nothing wrong here (below).Tested
testDebugUnitTestpasses all 26 tests (AAPI_00002: 10, 00003: 4, 00004: 3, 00005: 6, 00006: 3).Known consequence: the next driver bump will fail three tests
The next Java API release will include DEV-1337 (ShimmerResearch/Shimmer-Java-Android-API#339, still open): the driver will no longer write the clock (
SET_RWC) to a streaming Shimmer3R. AAPI_00002, AAPI_00003 and AAPI_00005 expectstartSDLogging()on a streaming Shimmer3R to queueSET_RWC_COMMAND, so they will fail on that release's bump PR until they are adapted. #339 adapted the driver's API_00027, API_00030 and API_00032 the same way. This PR does not change them.Companion: ShimmerResearch/Shimmer-Java-Android-API#341 adds the
update-androidjob that opens the bump PRs. It needs a newANDROID_REPO_TOKENsecret in that repo; this PR needs nothing added.🤖 Generated with Claude Code