Repository navigation
DEV-1247: BLE connect no longer blocks the main thread on the MTU; fail on notify/connect errors #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DEV-1247: BLE connect no longer blocks the main thread on the MTU; fail on notify/connect errors #129
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fdb0692
DEV-1247 BLE connect: don't block the main thread on the MTU; fail on…
JongChern f7a2398
DEV-1247 Review fixes: disconnect the callback's device; per-attempt …
JongChern d67ff5d
DEV-1247 Review fixes: fail a setup-time disconnect at once; ignore a…
JongChern 57f064b
DEV-1247 Review fix: carry the connect attempt's task through every s…
JongChern ef7f7d2
DEV-1247 Review fix: ignore a connect success from a superseded attempt
JongChern a0d676f
DEV-1247 Review fixes: a caller's disconnect during setup isn't a fai…
JongChern 5c8ecc1
DEV-1247 Review fix: ignore a superseded attempt's disconnect
JongChern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.