Skip to content

DEV-1115 Refuse a 'local' publish; add job timeouts - #126

Merged
JongChern merged 1 commit into
DEV-1115_release_workflowfrom
DEV-1115_release_workflow_fixes
Oct 18, 2026
Merged

JongChern merged 1 commit into
DEV-1115_release_workflowfrom
DEV-1115_release_workflow_fixes

Conversation

@MAzalya

@MAzalya MAzalya commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Fixes found while testing #123. This PR targets DEV-1115_release_workflow, so merging it folds the fixes into #123.

1. Refuse to publish version local

#123 turns the publishing block back on. Without -PreleaseVersion its version is local, and developers already keep gpr.key in ~/.gradle/gradle.properties to read the driver. So a hand-run gradlew publish would push local to GitHub Packages, which can never overwrite that version. Publishing to a remote repository now fails in that case. publishToMavenLocal is unaffected.

2. Job timeouts

30 minutes on the build job and 10 on the release job. A hung Gradle daemon on #124 held a runner for 6 hours.

Tested locally (JDK 17)

  • :ShimmerAndroidInstrumentDriver:assembleRelease -PdriverVersion=0.11.7_beta builds the 1.3 MB .aar.
  • Publishing to a local file repository:
    • Without -PreleaseVersion, it fails with the new message.
    • With -PreleaseVersion=0.0.0_test, it writes the .aar and POM.

Also checked on #123 as it stands: the version-and-driver step, run against the real tags and releases.

  • Blank inputs give 3.2.10_beta against driver 0.11.8_beta.
  • A PR run uses master's 0.11.7_beta.
  • 3.2.9_beta is refused (it exists as AndroidAPI_v3.2.9Beta).
  • 3.2.8_beta is refused (it exists as v3.2.8Beta).
  • Driver 9.9.9 is refused, even on a dry run.

Not changed here, for the author

  • Driver drift: the release builds only the library against the chosen driver, while CI builds the examples against master's default (0.11.7_beta). The combination that ships is never built with the examples.
  • Property names: the new publishing block reads gpr.user, but the read repositories in the root build.gradle read gpr.usr.

🤖 Generated with Claude Code

Re-enabling the publishing block means a hand-run `gradlew publish`
without -PreleaseVersion would push version 'local' to GitHub Packages,
where it can never be overwritten; developers already keep gpr.key in
GRADLE_USER_HOME for reading the driver. Publishing to a remote
repository now refuses 'local'; publishToMavenLocal is unaffected.

Add job timeouts so a hung Gradle daemon cannot hold a runner for the
default 6 hours (as happened to the CI run on #124).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@JongChern
JongChern merged commit d87514a into DEV-1115_release_workflow Oct 18, 2026
2 checks passed
JongChern added a commit that referenced this pull request Oct 18, 2026
Three follow-ups ahead of review:
- The release build job now also builds every example app against the
  driver this release ships with, before anything is published. ci.yml
  only ever builds them against master's default driver, so a release
  that picks a newer driver was never built with the examples (raised
  in #126). Both build steps pass the 4 GB daemon heap from #125.
- The publishing block accepts gpr.usr as well as gpr.user, since the
  root build.gradle reads gpr.usr (also raised in #126).
- actions/* steps are pinned to commit SHAs, matching #124: each is the
  commit its v4 tag points at today.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants